openshift
NO-JIRA: generate insightsdatagatherers when InsightsConfigAPI is enabled
When I was converting to gates I didn't notice InsightsConfigAPI. If it's appropriate, I'd like to gate the InsightsDataGathers on the previously existing InsightsConfigAPI instead of the new InsightsConfig I added. Is that appropriate?
/assign @tremes
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, tremes
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [deads2k]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@deads2k: This pull request explicitly references no jira issue.
In response to this:
When I was converting to gates I didn't notice
InsightsConfigAPI. If it's appropriate, I'd like to gate the InsightsDataGathers on the previously existingInsightsConfigAPIinstead of the newInsightsConfigI added. Is that appropriate?/assign @tremes
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD 8203151f085f2205ba7fa64f093a04a742d1cb87 and 2 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD ac9356ba178405e39af0a76adc7d20a529bd93af and 1 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD fe20d81121393552d2f4a3677241d04cab245c0c and 0 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/hold
Revision b4a1b441e077e0388e2a94ec8ae3ae886ca64686 was retested 3 times: holding
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema /hold cancel /test all
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD ba11c1587003dc84cb014fd8db3fa597a3faaa63 and 2 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD 16d44e6d3e7d50ab99e2abae42e1c419318a175f and 1 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD b01900f1982a40d2b71a3c742de5755f3f28264f and 0 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/hold
Revision b4a1b441e077e0388e2a94ec8ae3ae886ca64686 was retested 3 times: holding
Re-overriding since the override got cleared
/override ci/prow/verify-crd-schema
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
Re-overriding since the override got cleared
/override ci/prow/verify-crd-schema
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD 987b8890c273cdcc262028806fa85ae5ab3ed92f and 2 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD 0689f006bcdeccf685c75438835beffa8bb14db7 and 1 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/retest-required
Remaining retests: 0 against base HEAD d3b3bb16a38282191881195f617fd494a9cb922b and 0 for PR HEAD b4a1b441e077e0388e2a94ec8ae3ae886ca64686 in total
/hold
The upgrade minor job is presently broken, but I'd like to see this pass through that before merging.
Can unhold once https://github.com/openshift/release/pull/53843 is merged