api icon indicating copy to clipboard operation
api copied to clipboard

remove console v1alpha1 which was present since 4.12

Open deads2k opened this issue 1 year ago • 3 comments

deads2k avatar Apr 12 '24 15:04 deads2k

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Apr 12 '24 15:04 openshift-ci[bot]

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Apr 12 '24 16:04 openshift-ci[bot]

/lgtm

jhadvig avatar May 20 '24 10:05 jhadvig

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar May 20 '24 10:05 openshift-ci[bot]

@deads2k tagging the PR Just a question, is it by design that the v1alpha1 version stays in the v1 crd ? Also will open an followup to remove the conversion webhook server.

jhadvig avatar May 20 '24 10:05 jhadvig