api
api copied to clipboard
openshift
[ETCD-488] Move etcd hardware speed feature to GA
Hello @dusk125! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Can you either
- link to the automated tests results in periodic jobs running on a schedule to ensure regression protection both from the owning component and other components via side-effect (cluster-node-tuning-operator just benefited from such protection when an MCO PR broke them)
-
A direct QE sign off that this feature is ready.
See deeper examples of how to be promoted here: https://github.com/openshift/enhancements/blob/master/dev-guide/featuresets.md#id-like-to-declare-a-feature-accessible-by-default--what-is-the-process
@dusk125: This pull request references ETCD-488 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/hold
@dusk125 Apologies for the hold, but it seems like this addition will cause an increase in disruptions for SingleNode, we might want to consider what to do in this test and how we want to handle it for SNO.
/unhold
We decided to skip the test that would cause a high disruption, because the test currently only executes on techpreview, this shouldn't effect currently running SNO jobs. PR to skip test is here https://github.com/openshift/origin/pull/28800
It seems like we have enough runs of the [sig-etcd][OCPFeatureGate:HardwareSpeed][Serial] etcd is able to update the hardware speed test in the tech preview serial jobs where it is passing.
See periodic-ci-openshift-release-master-ci-4.16-e2e-aws-ovn-techpreview-serial and job history.
/override ci/prow/verify The provided above results are satisfactory and will allow the feature to be promoted to stable.
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify
In response to this:
/override ci/prow/verify The provided above results are satisfactory and will allow the feature to be promoted to stable.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
/retest-required
Remaining retests: 0 against base HEAD a20192e21ba643a051df614b01297319d6e27f60 and 2 for PR HEAD c36dff2b445eba6e64f7e2b2b730d6efa735c3e6 in total
/retest-required
Remaining retests: 0 against base HEAD 1dea0237181fc64493521c5e1b86ca4209019c75 and 1 for PR HEAD c36dff2b445eba6e64f7e2b2b730d6efa735c3e6 in total
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify
In response to this:
/override ci/prow/verify /lgtm
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dusk125, soltysh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [soltysh]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 931fa9860c014b362efae9ab34bfe83560211f8d and 2 for PR HEAD 4a017153daed9b37738f0c95f7a61e5cc6643e53 in total