api
api copied to clipboard
openshift
SPLAT-1452: Changed vcenter MaxItems to be 3 for TechPreview.
Changes
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when FeatureGate "VCenterMultiVCenters" is active
- Default FG remains 1 max vcenter
- Added example of new FeatureGateAwareMaxItems
Dependencies
- https://github.com/openshift/kubernetes-sigs-controller-tools/pull/19
Blocks
- https://github.com/openshift/installer/pull/8221
- https://github.com/openshift/machine-config-operator/pull/4298
- https://github.com/openshift/cluster-storage-operator/pull/465
- https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/228
@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
CHANGES
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when TechPreview
- Default FG remains 1 max vcenter
DEPENDENCIES
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.
In response to this:
Changes
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when TechPreview
- Default FG remains 1 max vcenter
Dependencies
- https://github.com/openshift/kubernetes-sigs-controller-tools/pull/19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.
In response to this:
Changes
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when FeatureGate "VCenterMultiVCenters" is active
- Default FG remains 1 max vcenter
- Added example of new FeatureGateAwareMaxItems
Dependencies
- https://github.com/openshift/kubernetes-sigs-controller-tools/pull/19
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.
In response to this:
Changes
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when FeatureGate "VCenterMultiVCenters" is active
- Default FG remains 1 max vcenter
- Added example of new FeatureGateAwareMaxItems
Dependencies
- https://github.com/openshift/kubernetes-sigs-controller-tools/pull/19
Blocks
- https://github.com/openshift/installer/pull/8221
- https://github.com/openshift/machine-config-operator/pull/4298
- https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/228
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.
In response to this:
Changes
- Created new VSphereMultiVCenters feature gate
- Generated new CRDs with max vcenter = 3 when FeatureGate "VCenterMultiVCenters" is active
- Default FG remains 1 max vcenter
- Added example of new FeatureGateAwareMaxItems
Dependencies
- https://github.com/openshift/kubernetes-sigs-controller-tools/pull/19
Blocks
- https://github.com/openshift/installer/pull/8221
- https://github.com/openshift/machine-config-operator/pull/4298
- https://github.com/openshift/cluster-storage-operator/pull/465
- https://github.com/openshift/vmware-vsphere-csi-driver-operator/pull/228
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
/retest-required
Remaining retests: 0 against base HEAD d591253b6b2968a5a72afcff9fb3007f5cd8a049 and 2 for PR HEAD a1c8128dbe8563943385fff413424c1377cdf036 in total
/override ci/prow/verify-crd-schema
Pre-existing failures being added to the new FeatureGated version of the file
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema
Pre-existing failures being added to the new FeatureGated version of the file
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/retest-required
Remaining retests: 0 against base HEAD 62b890e4c7cd2970e3340894b5ffff04bc67b17c and 1 for PR HEAD a1c8128dbe8563943385fff413424c1377cdf036 in total
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, vr4manta
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/retest-required
Remaining retests: 0 against base HEAD 62b890e4c7cd2970e3340894b5ffff04bc67b17c and 2 for PR HEAD 3a0f16fddc9251629168195aec5c4958a73c75fb in total
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema
Pre-existing failures, see previous
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@vr4manta: all tests passed!
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
[ART PR BUILD NOTIFIER]
This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405081611.p0.g95e2292.assembly.stream.el9 for distgit ose-cluster-config-api. All builds following this will include this PR.
