openshift
OCPBUGS-16418: Show more clear info about the DeploymentConfig is deprecated
- Updated deprecated from OCP 4.14 to the corresponding k8s 1.27
- Because this API is currently never going away, set removed=0.0
With these settings the warning header should change from this:
apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10
to
apps.openshift.io/v1 DeploymentConfig is deprecated in v1.27+
Open question:
Given that this type is never actually going to be removed, should we just remove the deprecation warning? Marking it as deprecated, usually starts the clock towards removal.
Hello @sanchezl! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sanchezl Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
- replace ocp versions with k8s versions
- update generated code
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
- Updated deprecated from OCP 4.14 to the corresponding k8s 1.27
- Because this API is currently never going away, set removed=0.0
With these settings the warning header should change from this:
apps.openshift.io/v1 DeploymentConfig is deprecated in v4.14+, unavailable in v4.10to
apps.openshift.io/v1 DeploymentConfig is deprecated in v1.27+Open question:
Given that this type is never actually going to be removed, should we just remove the deprecation warning? Marking it as deprecated, usually starts the clock towards removal.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @zhouying7780
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Given that this type is never actually going to be removed, should we just remove the deprecation warning?
The warning message is definitely annoying. +1 for removing it when listing all resources. I'd still prefer to keep it when CRUD'ing the DC resource.
Given that this type is never actually going to be removed, should we just remove the deprecation warning?
The warning message is definitely annoying. +1 for removing it when listing all resources. I'd still prefer to keep it when CRUD'ing the DC resource.
@ingvagabund I've opened a companion PR to remove the message completely from oc status and oc get all.
@sanchezl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-hypershift | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-ovn-techpreview | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-serial | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-aws-serial |
| ci/prow/e2e-upgrade | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-upgrade |
| ci/prow/e2e-upgrade-minor | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-serial-techpreview | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-aws-ovn | 5cd8fa507c007af43196cf49a544363015301e4d | link | true | /test e2e-aws-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.