api
api copied to clipboard
openshift
Add InPlacePodVerticalScaling featuregate (TechPreviewNoUpgrade)
This feature allows a pod spec's resource requests and limits to be modified, and is an important upcoming feature for Vertical Pod Autoscaler to be able to modify pods without evicting and replacing them.
Hello @joelsmith! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: joelsmith Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Changes look good, just for my own understanding, can you answer the following please.
What is the status of this featuregate upstream?
Can you confirm in which version it's introduced and whether it's been moved to beta yet?
Is there a plan for when it will be moved to GA?
Here is the upstream KEP:
https://github.com/kubernetes/enhancements/issues/1287
Changes look good, just for my own understanding, can you answer the following please.
What is the status of this featuregate upstream?
Disabled by default, and expected to remain so for a few versions. The plan is for it to be alpha also in v1.30
Can you confirm in which version it's introduced and whether it's been moved to beta yet?
It was added in v1.27, and won't be moved to beta until v1.31 at the earliest.
Is there a plan for when it will be moved to GA?
The KEP currently says past 1.32, so probably no earlier than 1.33.
/retest
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@joelsmith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-ovn-hypershift | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-upgrade | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-ovn | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-upgrade-minor | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-serial | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn-techpreview | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-serial-techpreview | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/minor-e2e-upgrade-minor | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/minor-images | 0b9cbf6fb4f2ba6262dbca00d60b748d120d5275 | link | true | /test minor-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.