api
api copied to clipboard
openshift
WIP: Migrate gengo v2
Working on moving our generators to the upstream WIP gengo v2 project.
Current issues I need to work through:
- [ ] Gengo v2 has no verify-only option which we rely on in deepcopy, prerelease-lifecycle generators
- [x] OpenAPI WIP branch is not up to date with K/K PR, so cannot integrate that yet
- [ ] Pre-release lifecycle gen not integrated with codegen, it would be easier to manage if it were, very black box and only working on apps API group right now
- [ ] Have a WIP proto integration to codegen that wasn't working in non GOPATH, may work now
- [x] Check if deepcopy etc works correctly in non-gopath
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [JoelSpeed]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test verify |
| ci/prow/e2e-upgrade-minor | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test verify |
| ci/prow/e2e-aws-serial-techpreview | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-upgrade | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-serial | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn-techpreview | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-ovn-hypershift | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-upgrade-minor | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-ovn | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test e2e-aws-ovn |
| ci/prow/minor-images | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test minor-images |
| ci/prow/minor-e2e-upgrade-minor | 12e546a73751285a722a5a51c2399d6473d5fa4b | link | true | /test minor-e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.