api
api copied to clipboard
openshift
OCPBUGS-25821: add MCO management of api-int CA
the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.
What I did here is
- add
KubeAPIServerClientCAto represent what was previously being stored inKubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity. - made
KubeAPIServerServingCADatastore the data for the api-int CA
Hello @cdoern! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is invalid:
- expected the bug to target the "4.16.0" version, but no target version was set
Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
In response to this:
the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cdoern Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is valid. The bug has been moved to the POST state.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @rioliu-rh
In response to this:
/jira refresh
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is valid.
3 validation(s) were run on this bug
- bug is open, matching expected state (open)
- bug target version (4.16.0) matches configured target version for branch (4.16.0)
- bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Requesting review from QA contact: /cc @sergiordlr
In response to this:
the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.
What I did here is
- add
KubeAPIServerClientCAto represent what was previously being stored inKubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity.- made
KubeAPIServerServingCADatastore the data for the api-int CA
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@cdoern: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-azure | fd7da999034cf564abe9dcbfc43558e84bbfeabf | link | false | /test e2e-azure |
| ci/prow/e2e-upgrade | fd7da999034cf564abe9dcbfc43558e84bbfeabf | link | true | /test e2e-upgrade |
| ci/prow/integration | bc13c17814d8f3e7c776d66dffffbb8177f52d60 | link | true | /test integration |
| ci/prow/e2e-upgrade-minor | bc13c17814d8f3e7c776d66dffffbb8177f52d60 | link | true | /test e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/close
We're going to close this and not do this management with an API process for now so its no longer attached to the bug. We'll revisit in newer versions
@yuqi-zhang: Closed this PR.
In response to this:
/close
We're going to close this and not do this management with an API process for now so its no longer attached to the bug. We'll revisit in newer versions
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@cdoern: This pull request references Jira Issue OCPBUGS-25821. The bug has been updated to no longer refer to the pull request using the external bug tracker.
In response to this:
the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.
What I did here is
- add
KubeAPIServerClientCAto represent what was previously being stored inKubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity.- made
KubeAPIServerServingCADatastore the data for the api-int CA
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.