api icon indicating copy to clipboard operation
api copied to clipboard

Add IBM Cloud managed annotations to network.operator CRD

Open kyrtapz opened this issue 2 years ago • 4 comments

Currently CNO applies the IBM Cloud managed annotation by patching the network.operator CRDs from the api: https://github.com/openshift/cluster-network-operator/blob/e23d612d00c74985ba1a4bfb84580dfbf19d77f0/hack/update-codegen.sh#L55-L66

Set the annotation directly in the API to avoid the extra step in CNO.

kyrtapz avatar Dec 22 '23 17:12 kyrtapz

Hello @kyrtapz! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Dec 22 '23 17:12 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kyrtapz Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Dec 22 '23 17:12 openshift-ci[bot]

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 6dc74aff34d82fac9e57614a0042f78ba5b9d348 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-minor 6dc74aff34d82fac9e57614a0042f78ba5b9d348 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 13:03 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Mar 19 '24 13:03 openshift-merge-robot