api icon indicating copy to clipboard operation
api copied to clipboard

operator/v1: Shift etcd CRD from level 12 to 20

Open wking opened this issue 2 years ago • 6 comments

Catching up with openshift/cluster-etcd-operator@b6ec3efca7 (openshift/cluster-etcd-operator#689) moving the other etcd manifests from level 12 to 20.

wking avatar Oct 26 '23 19:10 wking

Hello @wking! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Oct 26 '23 19:10 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Oct 26 '23 19:10 openshift-ci[bot]

verify-crd-schema failed:

F1026 19:20:40.797770    7028 root.go:64] Error running codegen: 
error running generator schemacheck on group operator.openshift.io: 
	could not run schemacheck generator for group/version operator.openshift.io/v1: 
		error in 0000_20_etcd-operator_01_config-TechPreviewNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.nodeStatuses must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config-TechPreviewNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.nodeStatuses[*].lastFailedRevisionErrors must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config-TechPreviewNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.generations must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config-TechPreviewNoUpgrade.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.generations must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.nodeStatuses must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.nodeStatuses[*].lastFailedRevisionErrors must set x-kubernetes-list-type
		error in 0000_20_etcd-operator_01_config.crd.yaml: ListsMustHaveSSATags: crd/etcds.operator.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type

That puts this in the same "do we need to fix this divergence of old code from new policies now or not?" issue that's holding up #1601. I'll idle this until we have a decision pull from API approvers.

wking avatar Oct 26 '23 19:10 wking

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test verify-crd-schema
ci/prow/e2e-aws-serial-techpreview 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-minor 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 13:03 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Mar 19 '24 13:03 openshift-merge-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 01:06 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 00:08 openshift-bot

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test verify-crd-schema
ci/prow/e2e-aws-serial 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-hypershift 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-techpreview 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade-minor 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial-techpreview 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test e2e-upgrade
ci/prow/minor-images 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test minor-images
ci/prow/minor-e2e-upgrade-minor 3aa240370dcb3fde863e6d0570c8a6c0b3d129e2 link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 15:08 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Sep 15 '24 00:09 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 15 '24 00:09 openshift-ci[bot]