openshift
ETCD-479: add node selectors and taints to etcdbackup
Adding the usual node selector/taint pair to the etcdbackups. That enables us and the customers to more accurately place where the backup is stored and taken from.
Primary use case would be to ensure the retention always runs on the same node as the backup is stored (eg in hostPath scenarios).
@tjungblu: This pull request references ETCD-479 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hello @tjungblu! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@tjungblu: This pull request references ETCD-479 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tjungblu Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@tjungblu: This pull request references ETCD-479 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.
In response to this:
Adding the usual node selector/taint pair to the etcdbackups. That enables us and the customers to more accurately place where the backup is stored and taken from.
Primary use case would be to ensure the retention always runs on the same node as the backup is stored (eg in hostPath scenarios).
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/verify-crd-schema | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test verify-crd-schema |
| ci/prow/e2e-aws-ovn-hypershift | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-serial-techpreview | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-upgrade | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-upgrade |
| ci/prow/e2e-upgrade-minor | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-ovn | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-aws-ovn-techpreview | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-serial | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test e2e-aws-serial |
| ci/prow/minor-e2e-upgrade-minor | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test minor-e2e-upgrade-minor |
| ci/prow/minor-images | c6f605ba871636f0a38ba0913610db293a52de06 | link | true | /test minor-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.