api icon indicating copy to clipboard operation
api copied to clipboard

[WIP] Add OpenShiftControlPlane v1alpha1 API

Open JoelSpeed opened this issue 1 year ago • 9 comments

Related to https://github.com/openshift/enhancements/pull/1479, this adds the API for the new OpenShiftControlPlane type that will be used to define how to bootstrap OpenShift clusters via Cluster API patterns.

This is part of an experiment and is yet to be proven, I will leave the PR as a draft until we are more confident in the approach we are building out.

JoelSpeed avatar Sep 26 '23 16:09 JoelSpeed

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Sep 26 '23 16:09 openshift-ci[bot]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 26 '23 16:09 openshift-ci[bot]

/approve cancel

I do not want this to be accidentally merged

JoelSpeed avatar Sep 26 '23 16:09 JoelSpeed

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign jwforres for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 26 '23 16:09 openshift-ci[bot]

/test verify

JoelSpeed avatar Sep 27 '23 08:09 JoelSpeed

/test verify

JoelSpeed avatar Sep 28 '23 13:09 JoelSpeed

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Jan 15 '24 10:01 openshift-merge-robot

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 09:06 openshift-bot

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-hypershift da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-upgrade-minor da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-upgrade-minor
ci/prow/e2e-upgrade da79a0cb2d3eb2e18e555e815b7581f7b5cf0c4b link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 16:07 openshift-ci[bot]

Not going to pursue this right now

JoelSpeed avatar Aug 09 '24 07:08 JoelSpeed