api icon indicating copy to clipboard operation
api copied to clipboard

extend the example integration test with set of strings attribute

Open tremes opened this issue 2 years ago • 5 comments

tremes avatar Sep 22 '23 13:09 tremes

Hello @tremes! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 22 '23 13:09 openshift-ci[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tremes Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Mar 19 '24 14:03 openshift-ci[bot]

@tremes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 3bef95d008914010373d87cc2105fa851114ee0c link true /test verify
ci/prow/e2e-upgrade-minor b000aa518821a91d1edf59410b088e85b91d5291 link true /test e2e-upgrade-minor
ci/prow/integration 3bef95d008914010373d87cc2105fa851114ee0c link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 15:03 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 19 '24 01:06 openshift-bot

@tremes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-upgrade
ci/prow/e2e-upgrade-minor 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial-techpreview 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial 3bef95d008914010373d87cc2105fa851114ee0c link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Jul 11 '24 16:07 openshift-ci[bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 00:08 openshift-bot

Hi @JoelSpeed do you want me to rebase it and keep it open or should I close it?

tremes avatar Aug 12 '24 05:08 tremes

Lets rebase and get this merged please

JoelSpeed avatar Aug 12 '24 06:08 JoelSpeed

OK rebased.

tremes avatar Aug 12 '24 08:08 tremes

/remove-lifecycle rotten

tremes avatar Aug 12 '24 09:08 tremes

/approve /lgtm

JoelSpeed avatar Aug 12 '24 09:08 JoelSpeed

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Aug 12 '24 09:08 openshift-ci[bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408121342.p0.g86145ed.assembly.stream.el9. All builds following this will include this PR.

openshift-bot avatar Aug 12 '24 15:08 openshift-bot