api
api copied to clipboard
openshift
NO-ISSUE: Fix mismatching spaces and tabs
Commit 2f259e8fcccdc7eaf21a2c17709cdd6bbaefdb6a introduced a change where spaces and tabs are mixed inside one single type definition. Because of that various code editors are reporting issues and display this struct in a badly formated way.
This PR modifies IBMCloudPlatformStatus definition to use consistent whitespacing.
@mkowalski: This pull request explicitly references no jira issue.
In response to this:
Commit 2f259e8fcccdc7eaf21a2c17709cdd6bbaefdb6a introduced a change where spaces and tabs are mixed inside one single type definition. Because of that various code editors are reporting issues and display this struct in a badly formated way.
This PR modifies
IBMCloudPlatformStatusdefinition to use consistent whitespacing.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hello @mkowalski! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@mkowalski: GitHub didn't allow me to request PR reviews from the following users: cjschaef.
Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.
In response to this:
/cc @cjschaef Author of original commit
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mkowalski Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-upgrade-minor | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-upgrade-minor | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-aws-serial-techpreview | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-upgrade | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-ovn-hypershift | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-ovn-techpreview | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-aws-ovn-techpreview |
| ci/prow/e2e-aws-serial | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn | 909bee861aba35f973626b31ca6dcfe2b8f466e0 | link | true | /test e2e-aws-ovn |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.