api icon indicating copy to clipboard operation
api copied to clipboard

Drop removed k8s.io/api/apps/v1beta1, k8s.io/api/apps/v1beta2 and k8s…

Open ingvagabund opened this issue 2 years ago • 6 comments

….io/api/extensions/v1beta1.Scale removed in k8s 1.16

Related: https://issues.redhat.com/browse/OCPBUGS-3850

@stlaz FYI

ingvagabund avatar Sep 14 '23 14:09 ingvagabund

Hello @ingvagabund! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] avatar Sep 14 '23 14:09 openshift-ci[bot]

Nice, thank you for looking into that @ingvagabund

dgrisonnet avatar Sep 14 '23 14:09 dgrisonnet

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgrisonnet, ingvagabund, stlaz Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci[bot] avatar Sep 15 '23 10:09 openshift-ci[bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot avatar Jan 15 '24 10:01 openshift-merge-robot

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-upgrade
ci/prow/e2e-upgrade-minor 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Mar 19 '24 13:03 openshift-ci[bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot avatar Jun 18 '24 09:06 openshift-bot

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot avatar Aug 11 '24 08:08 openshift-bot

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-upgrade
ci/prow/e2e-aws-serial-techpreview 494d19872a037987b152b7d7a6d0319c34c88022 link true /test e2e-aws-serial-techpreview
ci/prow/minor-e2e-upgrade-minor 494d19872a037987b152b7d7a6d0319c34c88022 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 494d19872a037987b152b7d7a6d0319c34c88022 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 15 '24 15:08 openshift-ci[bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-bot avatar Sep 15 '24 08:09 openshift-bot

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci[bot] avatar Sep 15 '24 08:09 openshift-ci[bot]