openshift
tls/MCO: Describe how `machine-config-server-tls` works
I didn't write this code, but some quick code searches reveals that what is formerly called "mco mystery cert" here is really the "MCS certificate" - it's generated by openshift/installer today, and then just passed into the cluster and used by the MCO.
Agreed with the implication here that "root-ca" is a terrible name for that CA, and it should probably be moved into the openshift-machine-config-operator namespace in the cluster and renamed.
We also really need to add day 2 rotation for this.
Hello @cgwalters! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cgwalters Once this PR has been reviewed and has the lgtm label, please assign eparis for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
This file is generated by https://github.com/openshift/cluster-debug-tools Glad to see details coming here.
@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-upgrade-minor | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-upgrade-minor |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle stale
@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/e2e-aws-serial-techpreview | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-aws-serial-techpreview |
| ci/prow/e2e-aws-ovn-hypershift | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-aws-ovn-hypershift |
| ci/prow/e2e-aws-serial | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-aws-serial |
| ci/prow/e2e-aws-ovn | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-aws-ovn |
| ci/prow/e2e-upgrade-minor | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-upgrade-minor |
| ci/prow/e2e-upgrade | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-upgrade |
| ci/prow/e2e-aws-ovn-techpreview | 236f29ed313423ccc3decaf81aceb2da1f0444ab | link | true | /test e2e-aws-ovn-techpreview |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.
If this issue is safe to close now please do so with /close.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.
/close
@openshift-bot: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting
/reopen. Mark the issue as fresh by commenting/remove-lifecycle rotten. Exclude this issue from closing again by commenting/lifecycle frozen./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.