pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Published 20 hours ago β€’ verified publisher icon openshift-pipelines

Show events in tkn pac describe

Open chmouel opened this issue 3 years ago β€’ 3 comments

  • Add a reason to every message emitted so it shows better. (and make it easy to fitler)

image

Signed-off-by: Chmouel Boudjnah [email protected]

Changes

Submitter Checklist

  • [ ] β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • [ ] πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • [ ] πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • [ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • [ ] πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

chmouel avatar Oct 20 '22 15:10 chmouel

I didn't take care of the events sorting, probably will do this next..

chmouel avatar Oct 20 '22 15:10 chmouel

Codecov Report

Merging #935 (e4ed779) into main (76de58f) will decrease coverage by 0.16%. The diff coverage is 37.93%.

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   63.82%   63.66%   -0.17%     
==========================================
  Files          81       82       +1     
  Lines        5269     5309      +40     
==========================================
+ Hits         3363     3380      +17     
- Misses       1587     1606      +19     
- Partials      319      323       +4
Impacted Files Coverage Ξ”
pkg/kubeinteraction/events.go 0.00% <0.00%> (ΓΈ)
pkg/pipelineascode/pipelineascode.go 24.61% <0.00%> (ΓΈ)
pkg/reconciler/reconciler.go 22.87% <0.00%> (ΓΈ)
pkg/pipelineascode/match.go 57.37% <40.00%> (ΓΈ)
pkg/cmd/tknpac/describe/describe.go 47.50% <42.42%> (-1.42%) :arrow_down:
pkg/events/emit.go 80.00% <100.00%> (+0.51%) :arrow_up:
pkg/templates/templating.go 100.00% <0.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 20 '22 15:10 codecov-commenter

the e2e failure will be fixed by https://github.com/tektoncd/catalog/pull/1094

chmouel avatar Oct 21 '22 07:10 chmouel