pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

[WIP]Add s390x, ppc64le architecture support

Open Basavaraju-G opened this issue 3 years ago โ€ข 8 comments

Changes

As of now pipeline-as-code runs on amd64 platform. This PR will Add support for ppc64le, s390x platform.

Submitter Checklist

  • [ ] โ™ฝ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • [ ] ๐Ÿ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • [ ] ๐Ÿงช 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • [ ] ๐ŸŽ If that's something that is possible to do please ensure to check if we can add a e2e test.
  • [ ] ๐Ÿ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

Basavaraju-G avatar Oct 16 '22 09:10 Basavaraju-G

@chmouel @sm43 would you please review this PR. Currently in my testing, it took only ~20min to build amd64/ppc64le/s390x multi-arch images compared to old builds with ~1Hr. Build details: https://github.com/Basavaraju-G/pipelines-as-code/actions Screenshot 2022-10-16 at 3 14 34 PM

Basavaraju-G avatar Oct 16 '22 10:10 Basavaraju-G

would it okay if we run this as nightly(once a day) rather than after each pr merge?

sm43 avatar Oct 17 '22 06:10 sm43

would it okay if we run this as nightly(once a day) rather than after each pr merge?

@sm43 I agree with you for nightly build. but i see for every PR we are running only "E2E Tests on kind". we are not running "Create and publish a Docker image" workflow. this changes only works on building image time. not for every PR.

Basavaraju-G avatar Oct 17 '22 06:10 Basavaraju-G

would it okay if we run this as nightly(once a day) rather than after each pr merge?

@sm43 I agree with you for nightly build. but i see for every PR we are running only "E2E Tests on kind". we are not running "Create and publish a Docker image" workflow. this changes only works on building image time. not for every PR.

yeah I meant for every merged PR. whenever a new PR is merged this is triggered

sm43 avatar Oct 17 '22 09:10 sm43

we were wondering if using ko can help us with this ๐Ÿค” https://github.com/marketplace/actions/setup-ko for multi platform images I need to try this out.

sm43 avatar Oct 17 '22 09:10 sm43

Can you add a new workflow with this changes running nightly? later if ko works as expected we can replace

sm43 avatar Oct 17 '22 11:10 sm43

/ok-to-test

chmouel avatar Oct 17 '22 14:10 chmouel

Can you add a new workflow with this changes running nightly? later if ko works as expected we can replace

thanks @sm43. i will add those changes.

Basavaraju-G avatar Oct 18 '22 06:10 Basavaraju-G