pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

tkn pac resolve doesn't work with git_auth_secret

Open chmouel opened this issue 3 years ago • 2 comments

since it doesn't get replaced it will fail...

chmouel avatar Sep 26 '22 13:09 chmouel

as controller creates the secret and replaces in pipelinerin for cli resolves.. are we thinking do the same? creating secret using cli?

sm43 avatar Sep 28 '22 10:09 sm43

I was thinking, we could just create a fake random secret on cluster and pass the name to the git_auth_secret variable so we could just make it works.

If user really want to setup a secret for private repo, they could pre-setup a secret and use the -p git_auth_secret=secret-name command line.

chmouel avatar Sep 28 '22 11:09 chmouel

If we generate a fake secret and pass then may be end user get confused thinking that by default it creates some secret :thinking:

How about adding git_auth_secret only when user pass it using -p git_auth_secret=secret-name command line ?

savitaashture avatar Nov 23 '22 08:11 savitaashture

@savitaashture that sounds a better idea to me!

chmouel avatar Nov 23 '22 08:11 chmouel