pipelines-as-code
pipelines-as-code copied to clipboard
tkn pac resolve doesn't work with git_auth_secret
since it doesn't get replaced it will fail...
as controller creates the secret and replaces in pipelinerin for cli resolves.. are we thinking do the same? creating secret using cli?
I was thinking, we could just create a fake random secret on cluster and pass the name to the git_auth_secret variable so we could just make it works.
If user really want to setup a secret for private repo, they could pre-setup a secret and use the -p git_auth_secret=secret-name command line.
If we generate a fake secret and pass then may be end user get confused thinking that by default it creates some secret :thinking:
How about adding git_auth_secret only when user pass it using -p git_auth_secret=secret-name command line ?
@savitaashture that sounds a better idea to me!