pipelines-as-code
pipelines-as-code copied to clipboard
Emits metrics for PAC pipelineruns with provider info

Signed-off-by: Shivam Mukhade [email protected]
Changes
Submitter Checklist
- [ ] β½ Run
make test lintbefore submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI - [ ] π If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
- [ ] π§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
- [ ] π If that's something that is possible to do please ensure to check if we can add a e2e test.
- [ ] π If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).
Codecov Report
Merging #774 (51a7839) into main (c3660fa) will decrease coverage by
0.00%. The diff coverage is46.66%.
@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 65.77% 65.76% -0.01%
==========================================
Files 75 75
Lines 4590 4621 +31
==========================================
+ Hits 3019 3039 +20
- Misses 1282 1290 +8
- Partials 289 292 +3
| Impacted Files | Coverage Ξ | |
|---|---|---|
| pkg/reconciler/controller.go | 0.00% <0.00%> (ΓΈ) |
|
| pkg/reconciler/reconciler.go | 20.56% <63.63%> (+3.64%) |
:arrow_up: |
| pkg/matcher/cel.go | 82.75% <0.00%> (+0.14%) |
:arrow_up: |
| pkg/kubeinteraction/wait.go | 71.42% <0.00%> (+4.76%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
is the e2e failure a failure?
ah it should pass π€ let me retrigger
@chmouel example of the bug π failed to report status of one
which bug?
which bug?
https://github.com/openshift-pipelines/pipelines-as-code/issues/786
/retest pipeline-as-code-on-pull-request
did you see it on cluster? being the same issue?
did you see it on cluster? being the same issue?
I triggered the CI yesterday evening so cluster was reinstalled so I am pretty sure the bug was the issue π
weird that leaves our theory on other operator changing the structure...
I think I need to get the gitlab driver in and we can start doing some benchmarking.... let's discuss this in the #786 issue