pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Emits metrics for PAC pipelineruns with provider info

Open sm43 opened this issue 3 years ago β€’ 3 comments

image (2)

Signed-off-by: Shivam Mukhade [email protected]

Changes

Submitter Checklist

  • [ ] β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • [ ] πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • [ ] πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • [ ] 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • [ ] πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

sm43 avatar Jul 27 '22 09:07 sm43

Codecov Report

Merging #774 (51a7839) into main (c3660fa) will decrease coverage by 0.00%. The diff coverage is 46.66%.

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   65.77%   65.76%   -0.01%     
==========================================
  Files          75       75              
  Lines        4590     4621      +31     
==========================================
+ Hits         3019     3039      +20     
- Misses       1282     1290       +8     
- Partials      289      292       +3     
Impacted Files Coverage Ξ”
pkg/reconciler/controller.go 0.00% <0.00%> (ΓΈ)
pkg/reconciler/reconciler.go 20.56% <63.63%> (+3.64%) :arrow_up:
pkg/matcher/cel.go 82.75% <0.00%> (+0.14%) :arrow_up:
pkg/kubeinteraction/wait.go 71.42% <0.00%> (+4.76%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 27 '22 09:07 codecov-commenter

is the e2e failure a failure?

chmouel avatar Sep 01 '22 09:09 chmouel

ah it should pass πŸ€” let me retrigger

sm43 avatar Sep 01 '22 12:09 sm43

@chmouel example of the bug πŸ˜„ failed to report status of one

sm43 avatar Sep 02 '22 04:09 sm43

which bug?

chmouel avatar Sep 02 '22 08:09 chmouel

which bug?

https://github.com/openshift-pipelines/pipelines-as-code/issues/786

sm43 avatar Sep 02 '22 08:09 sm43

/retest pipeline-as-code-on-pull-request

sm43 avatar Sep 02 '22 08:09 sm43

did you see it on cluster? being the same issue?

chmouel avatar Sep 02 '22 08:09 chmouel

did you see it on cluster? being the same issue?

I triggered the CI yesterday evening so cluster was reinstalled so I am pretty sure the bug was the issue πŸ˜…

sm43 avatar Sep 02 '22 08:09 sm43

weird that leaves our theory on other operator changing the structure...

I think I need to get the gitlab driver in and we can start doing some benchmarking.... let's discuss this in the #786 issue

chmouel avatar Sep 02 '22 09:09 chmouel