pipelines-as-code
pipelines-as-code copied to clipboard
openshift-pipelines
skipped run doesn't seem to be cleared after being allowed
if:
- non allowed user submit a PR
- PAC deny it with a :
- other Allowed user send a /ok-to-test
- PR gets started
- it gets tested as such :
- but old status is still there :
when it should have been cleared,
I did add some code for this to clear the old statuses, i wonder since we moved to a reconciler we lost that feature..
example in this repo: https://github.com/redhat-appstudio/application-service/pull/133
cc @sm43
not sure 🤔 usually while testing this case never occurred 😅 https://github.com/openshift-pipelines/pipelines-as-code/blob/1814723efe1daea9fb2fb687fb0060f7664fb79c/pkg/provider/github/status.go#L58 we need a check here if title is skipped then delete it wdyt? I am sure where we used to handle that 🤔
maybe check in there if there is multiple check runs previously that is coming from pipelines as code that has "skipped" status and clear it? i guess that woudl work because at this time we are in allowed and running mode?
(sorry if this is not clear)
maybe check in there if there is multiple check runs previously that is coming from pipelines as code that has "skipped" status and clear it? i guess that woudl work because at this time we are in allowed and running mode?
(sorry if this is not clear)
yeah this would work, checking status and clearing them
