pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Published 20 hours ago • verified publisher icon openshift-pipelines

add a message in namespace event stream when token has expired

Open chmouel opened this issue 3 years ago • 2 comments

user would not know about it otherwise, we cannot update the providder UI since well we don't have a valid token (edited)

chmouel avatar May 09 '22 10:05 chmouel

It would be helpful to surface this where possible. As @chmouel suggested an event in the user namespace could be a good way to inform the user.

What are the steps for replacing the token. Could CLI help with that?

siamaksade avatar May 09 '22 10:05 siamaksade

partial address this with documentation here: #651

chmouel avatar May 09 '22 11:05 chmouel

I don't have a screenshot handy since i don't have a token expired but we have added token expiration check in the code which get logged back in the user namespace..

code is here https://github.com/openshift-pipelines/pipelines-as-code/blob/57d9bf28f3b941cdab247e090296a010b41b2c4e/pkg/provider/github/github.go#L168-L172

closing this

chmouel avatar Dec 08 '22 06:12 chmouel