pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

GitHub App: supporting check_suite event

Open sm43 opened this issue 3 years ago • 3 comments

If we configure GitHub app and if the user pipelinerun fails, on the github checks page we get option to

  • re-run failed jobs (emits a check_run event) and
  • re-run all jobs (emits a check_suite event)

we are currently supporting check_run event but not check_suite because check_suite event (rerequested action) is also emited when we push a new commit to a pull request so we need to filter out the check_run event which is coming from clicking the button and not pushing commits

image

sm43 avatar Apr 11 '22 08:04 sm43

that's fixed right?

chmouel avatar Dec 08 '22 08:12 chmouel

nope.. I don't remember this exactly but when Re-run all checks is clicked, check_suite event is generated which is not currently supported, we filter it out

this is nice to have, lets keep in backlog.. I need to check this once but the UI is already there we just need to configure it properly in PAC

sm43 avatar Dec 09 '22 06:12 sm43

ah i see yeah, so in your issue you meant :

"ReRun all checks" should restart every PipelineRun/Check-Run since it's currently not working.

(better state the problem before the possible solutions in your issue description :)

chmouel avatar Dec 09 '22 06:12 chmouel