pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Make sure we collect the right pruns for the Queue to proceed

Open chmouel opened this issue 1 year ago โ€ข 1 comments

When initializing the queues, we need to make sure we only collect the pruns that we want to for pending and running queues.

This filter out as well the non existent ones, in case if it was deleted but we have the old one referencing it in its state.

Changes

Submitter Checklist

  • [ ] ๐Ÿ“ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • [ ] โ™ฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • [ ] โœจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • [ ] ๐Ÿ“– If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • [ ] ๐Ÿงช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • [ ] ๐ŸŽ If feasible, please check if an end-to-end test can be added. See README for more details.

  • [ ] ๐Ÿ”Ž If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

chmouel avatar Oct 25 '24 11:10 chmouel