pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Fix tag ref for Bitbucket Cloud

Open riddler7 opened this issue 1 year ago โ€ข 0 comments

Changes

The Bitbucket Cloud webhook payload does not include refs/tags in the branch name. This means the using something like pipelinesascode.tekton.dev/on-target-branch: "[refs/tags/*]" does not work. This PR sets the branch name to refs/tags/tag when the change type is tag.

There is a slight concern around backwards compatibility if someone was using something like pipelinesascode.tekton.dev/on-target-branch: "[1.*]", as the source_branch variable will no longer be the tag, but refs/tags/tag. When testing this, while the tag was matched for the pipeline, the source_branch was empty.

Submitter Checklist

  • [ ] ๐Ÿ“ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • [ ] โ™ฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • [ ] โœจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • [ ] ๐Ÿ“– If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • [ ] ๐Ÿงช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • [ ] ๐ŸŽ If feasible, please check if an end-to-end test can be added. See README for more details.

  • [ ] ๐Ÿ”Ž If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

riddler7 avatar Oct 17 '24 00:10 riddler7