pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Fix panic issue when concurrency is set for global repo

Open savitaashture opened this issue 1 year ago โ€ข 2 comments

The PAC watcher encounters a panic error when concurrency is set on the global repository. This PR addresses the issue by checking for nil before accessing the ConcurrencyLimit directly.

Signed-off-by: Savita Ashture [email protected]

Changes

Submitter Checklist

  • [ ] ๐Ÿ“ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).

  • [ ] โ™ฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.

  • [ ] โœจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).

  • [ ] ๐Ÿ“– If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.

  • [ ] ๐Ÿงช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.

  • [ ] ๐ŸŽ If feasible, please check if an end-to-end test can be added. See README for more details.

  • [ ] ๐Ÿ”Ž If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).

savitaashture avatar Jun 14 '24 17:06 savitaashture

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.68%. Comparing base (35d7f7c) to head (fdf40db). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1715      +/-   ##
==========================================
+ Coverage   64.67%   64.68%   +0.01%     
==========================================
  Files         145      145              
  Lines       11192    11196       +4     
==========================================
+ Hits         7238     7242       +4     
  Misses       3426     3426              
  Partials      528      528              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 14 '24 17:06 codecov[bot]

Find by me but we can have a e2e test for this

chmouel avatar Jun 21 '24 07:06 chmouel

closing this PR as @zakisk is working on to raise a PR with e2e tests

savitaashture avatar Jul 26 '24 06:07 savitaashture