pipelines-as-code
pipelines-as-code copied to clipboard
[DNM] [Backport] Make sure to check if we can make API calls
- We didn't check for the error, which could crash the tekton controller. That call is the first API call we make so is the first one that would crash. Report the run as error if that happen, since it's probably a GitHub API outage (and a lot of other things would be wrong)
- Add 027d39f3104d9f54557e5d23505f854e4abd9d1d https://issues.redhat.com/browse/SRVKP-5507
Signed-off-by: Chmouel Boudjnah [email protected]# Changes
Submitter Checklist
-
[ ] ๐ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
-
[ ] โฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
-
[ ] โจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
-
[ ] ๐ If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
-
[ ] ๐งช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
-
[ ] ๐ If feasible, please check if an end-to-end test can be added. See README for more details.
-
[ ] ๐ If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).
Codecov Report
Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.
Project coverage is 63.17%. Comparing base (
7d026f4) to head (027d39f). Report is 1 commits behind head on release-v0.24.x.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/provider/github/github.go | 70.00% | 2 Missing and 1 partial :warning: |
| pkg/consoleui/custom.go | 94.59% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## release-v0.24.x #1700 +/- ##
===================================================
- Coverage 63.19% 63.17% -0.02%
===================================================
Files 139 139
Lines 10762 10762
===================================================
- Hits 6801 6799 -2
- Misses 3436 3438 +2
Partials 525 525
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.