pipelines-as-code
pipelines-as-code copied to clipboard
let the user pass arguments as parameters to gitops comments
when doing a /test, /retest or on gitops-comments we can now redefine the paramers, you can define standard params and custom params.
Format supported for args are:
test=foo bar="foo bar" hello=""world""
see documentation on this commit for details
Demo: (the issue of passing arguments on /test has been fixed since that demo was made)
https://github.com/openshift-pipelines/pipelines-as-code/assets/98980/134ab2ed-6039-495c-8d09-82bbe6a76d93
TODO: e2e tests
Signed-off-by: Chmouel Boudjnah [email protected]
Changes
Submitter Checklist
-
[ ] ๐ Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
-
[ ] โฝ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
-
[ ] โจ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
-
[ ] ๐ If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
-
[ ] ๐งช While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
-
[ ] ๐ If feasible, please check if an end-to-end test can be added. See README for more details.
-
[ ] ๐ If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).