pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

`tkn pac create repo` does not work as expected while using PAC with GHE

Open PuneetPunamiya opened this issue 1 year ago • 2 comments

Expected Behaviour :

  • While using pac via Github App, after Github App is installed, while running tkn pac create repo command it should directly generate the pipelinerun yaml and create the repository CR

Actual Behaviour:

  • While using pac via Github App, after Github App is installed, while running tkn pac create repo command it does not generate the pipelinerun yaml and also asks for access token

Steps to reproduce

  • Run tkn pac bootstrap --github-api-url https://ghe.xxx.com/
  • Run tkn pac create repo . After that while executing it asks for personal access token which it should not ask ideally
 tkn pac create repo                                                                                    
? Enter the Git repository url (default: https://ghe.xxx.com/pac/test-incoming-webhook):  
? Please enter the namespace where the pipeline should run (default: test-incoming-webhook-pipelines): 
! Namespace test-incoming-webhook-pipelines is not found
? Would you like me to create the namespace test-incoming-webhook-pipelines? Yes
✓ Repository pac-test-incoming-webhook has been created in test-incoming-webhook-pipelines namespace
? Please select the type of the git platform to setup webhook: github  👈🏻  Ideally it should skip from here 
✓ Setting up GitHub Webhook for Repository https://ghe.xxx.com/pac/test-incoming-webhook
👀 I have detected a controller url: https://controller.url.com/
? Do you want me to use it? Yes
? Please enter the secret to configure the webhook for payload validation (default: xxxxx):  xxxxx
ℹ ️You now need to create a GitHub personal access token, please checkout the docs at https://is.gd/KJ1dDH for the required scopes
? Please enter the GitHub access token:  
Error: interrupt

PuneetPunamiya avatar Feb 13 '24 18:02 PuneetPunamiya

I also faced this issue while tkn pac create repo on ghe.

rupalibehera avatar Feb 15 '24 07:02 rupalibehera

Yes this is valid issue today create repo command doesn't work well with GHE

savitaashture avatar Feb 15 '24 08:02 savitaashture