pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Published 20 hours ago • verified publisher icon openshift-pipelines

Check we are not creating repo in kube* or openshift* namespaces with tkn pac repo create

Open chmouel opened this issue 2 years ago • 4 comments

this has some unexpected behaviour where the default SA would not be available anymore! and it's probably bad practice to create "workload" in system namespaces...

chmouel avatar Jul 04 '23 14:07 chmouel

we warn to WARN right? and not decline the request

sm43 avatar Jul 07 '23 07:07 sm43

I think it was reported as not working when creating there since we don't auto create the service account in there

chmouel avatar Jul 07 '23 10:07 chmouel

in case of openshift, denying might be okay openshift-* namespaces but in case of kube, we probably just WARN and create if user says YES.

sm43 avatar Jul 07 '23 12:07 sm43

sure! i just add kube-* for completeness to be honest...

chmouel avatar Jul 07 '23 14:07 chmouel