pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Clarification task resolution in shared pipeline

Open mpreu opened this issue 2 years ago • 1 comments

Hi,

it would be nice if resolving remote pipeline definitions could be documented in more detail, specifically how Tasks are resolved from such a reference.

My current understanding (and after some tests using 0.17.x) is that:

  • Remote annotations only work on the PipelineRun level
  • I still have to add task annotations for every task of the remote Pipeline definition in the PipelineRun

This was at least my result after trying to share a linter pipeline across multiple repositories within an organization. In this scenario the referenced pipeline is inside a catalog repository within the org.

If this is correct, I think the documentation should clarify that in more detail. Furthermore, I think this behavior is rather inconvenient as I still have to write references for each task, although I wanted to share exactly this type of information across.

Feature request:

  • Remote URL task annotations should be supported on a referenced Pipeline
  • Ideally, local task annotations should be supported on the referenced Pipeline as well

mpreu avatar Apr 26 '23 20:04 mpreu

That's correct the remote annotations are only supported on the PipelineRun and not on the remote Pipeline,

I don't think there is any reasons we could not add this on remote Pipeline and it would be indeed rather more convenient.

We probably will have the PipelineRun annotation "wins" if there is conflict...

chmouel avatar Apr 27 '23 12:04 chmouel