pipelines-as-code icon indicating copy to clipboard operation
pipelines-as-code copied to clipboard

Skipped user case creates a new checkrun

Open sm43 opened this issue 2 years ago • 2 comments

If CI has ran, PAC has created checkruns for the Pipelineruns and later if any unauthorised user comment /retest or /ok-to-test PAC creates a new checkrun for skipped notification instead of using existing.

PAC should reuse existing because we can't delete a checkrun so once the CI is triggered by authorised user, the checkrun will still be there and can't be removed and we have 2 pipelineruns so one checkrun will be there with invalid details

image

sm43 avatar Jan 05 '23 11:01 sm43

you didn't fix that previously?

chmouel avatar Jan 09 '23 08:01 chmouel

this is similar but a different case that was pull request created by a non-authorised user and the checkrun needs to be reused.

in this case pull req is created by authorised user but a non-authorised user comment, then it creates a new checkrun instead of using existing the code is written in such a way this is happening, which need to be fixed

sm43 avatar Jan 09 '23 11:01 sm43