pipeline-service icon indicating copy to clipboard operation
pipeline-service copied to clipboard

Published 20 hours ago • verified publisher icon openshift-pipelines

[WIP] Fix tekton results storage configurations

Open sayan-biswas opened this issue 1 year ago • 12 comments

  • Add minio user creation through tenant, and disable TLS
  • Add minio and postgres as multiple sources in pipeline storage argocd application
  • Increase timeouts
  • Fix reset script
  • Add pipeline service monitoring application to reset script

sayan-biswas avatar Jun 16 '23 11:06 sayan-biswas

@sayan-biswas the upgrade test failure and at first blush does not seem like a flake:

+ kubectl apply -k /source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com
Error from server (Invalid): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{},\"name\":\"pipeline-service\",\"namespace\":\"openshift-gitops\"},\"spec\":{\"destination\":{\"namespace\":\"pipeline-service\",\"server\":\"https://kubernetes.default.svc\"},\"project\":\"default\",\"sources\":[{\"path\":\"developer/openshift/gitops/argocd/pipeline-service\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"43e768066fa0f61b9634127d8280be634d48cdce\"}],\"syncPolicy\":{\"automated\":{\"prune\":true,\"selfHeal\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"syncOptions\":[\"CreateNamespace=true\"]}}}\n"}},"spec":{"destination":{"namespace":"pipeline-service"},"source":null,"sources":[{"path":"developer/openshift/gitops/argocd/pipeline-service","repoURL":"https://github.com/openshift-pipelines/pipeline-service.git","targetRevision":"43e768066fa0f61b9634127d8280be634d48cdce"}]}}
to:
Resource: "argoproj.io/v1alpha1, Resource=applications", GroupVersionKind: "argoproj.io/v1alpha1, Kind=Application"
Name: "pipeline-service", Namespace: "openshift-gitops"
for: "/source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com": error when patching "/source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com":  "" is invalid: patch: Invalid value: "{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{\"kubectl.kubernetes.io/last-applied-configuration\":\"{\\\"apiVersion\\\":\\\"argoproj.io/v1alpha1\\\",\\\"kind\\\":\\\"Application\\\",\\\"metadata\\\":{\\\"annotations\\\":{},\\\"name\\\":\\\"pipeline-service\\\",\\\"namespace\\\":\\\"openshift-gitops\\\"},\\\"spec\\\":{\\\"destination\\\":{\\\"namespace\\\":\\\"pipeline-service\\\",\\\"server\\\":\\\"https://kubernetes.default.svc\\\"},\\\"project\\\":\\\"default\\\",\\\"sources\\\":[{\\\"path\\\":\\\"developer/openshift/gitops/argocd/pipeline-service\\\",\\\"repoURL\\\":\\\"https://github.com/openshift-pipelines/pipeline-service.git\\\",\\\"targetRevision\\\":\\\"43e768066fa0f61b9634127d8280be634d48cdce\\\"}],\\\"syncPolicy\\\":{\\\"automated\\\":{\\\"prune\\\":true,\\\"selfHeal\\\":true},\\\"retry\\\":{\\\"backoff\\\":{\\\"duration\\\":\\\"10s\\\",\\\"factor\\\":2,\\\"maxDuration\\\":\\\"3m\\\"},\\\"limit\\\":-1},\\\"syncOptions\\\":[\\\"CreateNamespace=true\\\"]}}}\\n\"},\"creationTimestamp\":\"2023-06-18T23:14:51Z\",\"generation\":59,\"managedFields\":[{\"apiVersion\":\"argoproj.io/v1alpha1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuration\":{}}},\"f:spec\":{\".\":{},\"f:destination\":{\".\":{},\"f:namespace\":{},\"f:server\":{}},\"f:project\":{},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}},\"f:syncPolicy\":{\".\":{},\"f:automated\":{\".\":{},\"f:prune\":{},\"f:selfHeal\":{}},\"f:retry\":{\".\":{},\"f:backoff\":{\".\":{},\"f:duration\":{},\"f:factor\":{},\"f:maxDuration\":{}},\"f:limit\":{}},\"f:syncOptions\":{}}}},\"manager\":\"kubectl-client-side-apply\",\"operation\":\"Update\",\"time\":\"2023-06-18T23:14:51Z\"},{\"apiVersion\":\"argoproj.io/v1alpha1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:status\":{\".\":{},\"f:conditions\":{},\"f:health\":{\".\":{},\"f:status\":{}},\"f:history\":{},\"f:operationState\":{\".\":{},\"f:finishedAt\":{},\"f:message\":{},\"f:operation\":{\".\":{},\"f:initiatedBy\":{\".\":{},\"f:automated\":{}},\"f:retry\":{\".\":{},\"f:backoff\":{\".\":{},\"f:duration\":{},\"f:factor\":{},\"f:maxDuration\":{}},\"f:limit\":{}},\"f:sync\":{\".\":{},\"f:prune\":{},\"f:resources\":{},\"f:revision\":{},\"f:syncOptions\":{}}},\"f:phase\":{},\"f:startedAt\":{},\"f:syncResult\":{\".\":{},\"f:resources\":{},\"f:revision\":{},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}}}},\"f:reconciledAt\":{},\"f:resources\":{},\"f:sourceType\":{},\"f:summary\":{\".\":{},\"f:images\":{}},\"f:sync\":{\".\":{},\"f:comparedTo\":{\".\":{},\"f:destination\":{\".\":{},\"f:namespace\":{},\"f:server\":{}},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}}},\"f:revision\":{},\"f:status\":{}}}},\"manager\":\"Go-http-client\",\"operation\":\"Update\",\"time\":\"2023-06-18T23:19:12Z\"}],\"name\":\"pipeline-service\",\"namespace\":\"openshift-gitops\",\"resourceVersion\":\"19301\",\"uid\":\"c17d3189-5446-4816-a8c4-e6adc451dbbe\"},\"spec\":{\"destination\":{\"namespace\":\"pipeline-service\",\"server\":\"https://kubernetes.default.svc\"},\"project\":\"default\",\"sources\":[{\"path\":\"developer/openshift/gitops/argocd/pipeline-service\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"43e768066fa0f61b9634127d8280be634d48cdce\"}],\"syncPolicy\":{\"automated\":{\"prune\":true,\"selfHeal\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"syncOptions\":[\"CreateNamespace=true\"]}},\"status\":{\"conditions\":[{\"lastTransitionTime\":\"2023-06-18T23:17:07Z\",\"message\":\"CustomResourceDefinition/repositories.pipelinesascode.tekton.dev is part of applications pipeline-service and build\",\"type\":\"SharedResourceWarning\"}],\"health\":{\"status\":\"Healthy\"},\"history\":[{\"deployStartedAt\":\"2023-06-18T23:15:02Z\",\"deployedAt\":\"2023-06-18T23:17:07Z\",\"id\":0,\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}}],\"operationState\":{\"finishedAt\":\"2023-06-18T23:19:12Z\",\"message\":\"successfully synced (all tasks run)\",\"operation\":{\"initiatedBy\":{\"automated\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"sync\":{\"prune\":true,\"resources\":[{\"kind\":\"Namespace\",\"name\":\"tekton-results\"}],\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"syncOptions\":[\"CreateNamespace=true\"]}},\"phase\":\"Succeeded\",\"startedAt\":\"2023-06-18T23:19:12Z\",\"syncResult\":{\"resources\":[{\"group\":\"\",\"hookPhase\":\"Running\",\"kind\":\"Namespace\",\"message\":\"namespace/tekton-results configured\",\"name\":\"tekton-results\",\"namespace\":\"openshift-gitops\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v1\"}],\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}}},\"reconciledAt\":\"2023-06-18T23:19:12Z\",\"resources\":[{\"kind\":\"ConfigMap\",\"name\":\"config-logging\",\"namespace\":\"openshift-pipelines\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"pipelines-as-code\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"pipelines-as-code-config-observability\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"pipelines-as-code-info\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"chains-config\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"chains-info\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"config-logging\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"tekton-results-api-config\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"tekton-results-config-leader-election\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"tekton-results-config-logging\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"tekton-results-config-observability\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ConfigMap\",\"name\":\"tekton-results-info\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"Namespace\",\"name\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"Namespace\",\"name\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"Namespace\",\"name\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"Secret\",\"name\":\"pipelines-as-code-webhook-certs\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"pipeline-metrics-exporter-service\",\"namespace\":\"openshift-pipelines\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"pipelines-as-code-controller\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"pipelines-as-code-watcher\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"pipelines-as-code-webhook\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"tekton-results-api-service\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"health\":{\"status\":\"Healthy\"},\"kind\":\"Service\",\"name\":\"tekton-results-watcher\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"pipeline-service-exporter\",\"namespace\":\"openshift-pipelines\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"pipelines-as-code-controller\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"pipelines-as-code-watcher\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"pipelines-as-code-webhook\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"chains-secrets-admin\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"tekton-chains-controller\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"tekton-results-api\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"kind\":\"ServiceAccount\",\"name\":\"tekton-results-watcher\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apiextensions.k8s.io\",\"kind\":\"CustomResourceDefinition\",\"name\":\"repositories.pipelinesascode.tekton.dev\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"pipeline-metrics-exporter\",\"namespace\":\"openshift-pipelines\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"pipelines-as-code-controller\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"pipelines-as-code-watcher\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"pipelines-as-code-webhook\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"tekton-chains-controller\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"tekton-results-api\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"apps\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Deployment\",\"name\":\"tekton-results-watcher\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"batch\",\"health\":{\"status\":\"Healthy\"},\"kind\":\"Job\",\"name\":\"tekton-chains-signing-secret\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"monitoring.coreos.com\",\"kind\":\"ServiceMonitor\",\"name\":\"pipelines-as-code-monitor\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"operator.tekton.dev\",\"kind\":\"TektonConfig\",\"name\":\"config\",\"status\":\"Synced\",\"version\":\"v1alpha1\"},{\"group\":\"operators.coreos.com\",\"health\":{\"message\":\"1: CatalogSourcesUnhealthy | False\\n\",\"status\":\"Healthy\"},\"kind\":\"Subscription\",\"name\":\"openshift-pipelines-operator\",\"namespace\":\"openshift-operators\",\"status\":\"Synced\",\"version\":\"v1alpha1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"openshift-gitops-apply-tekton-config-parameters\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"openshift-gitops-pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"pipeline-as-code-controller-clusterrole\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"pipeline-as-code-watcher-clusterrole\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"pipeline-as-code-webhook-clusterrole\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"pipeline-service-exporter-reader\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"pipelines-as-code-aggregate\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-chains-controller-cluster-access\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-chains-controller-tenant-access\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-chains-public-key-viewer\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-results-admin\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-results-api\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-results-readonly\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-results-readwrite\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"tekton-results-watcher\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"openshift-gitops-apply-tekton-config-parameters\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"openshift-gitops-pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"pipeline-service-exporter-reader-binding\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"pipelines-as-code-controller-clusterbinding\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"pipelines-as-code-watcher-clusterbinding\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"pipelines-as-code-webhook-clusterbinding\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"tekton-chains-controller-cluster-access\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"tekton-chains-controller-tenant-access\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"tekton-results-api\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"tekton-results-watcher\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"tekton-results-watcher-logs\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"secret-reader\",\"namespace\":\"openshift-ingress-operator\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"pipelines-as-code-controller-role\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"pipelines-as-code-info\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"pipelines-as-code-monitoring\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"pipelines-as-code-watcher-role\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"pipelines-as-code-webhook-role\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"chains-secret-admin\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"tekton-chains-info\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"tekton-chains-leader-election\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"Role\",\"name\":\"tekton-results-info\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"chains-secret-reader\",\"namespace\":\"openshift-ingress-operator\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"pipelines-as-code-controller-binding\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"pipelines-as-code-info\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"pipelines-as-code-monitoring\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"pipelines-as-code-watcher-binding\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"pipelines-as-code-webhook-binding\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"chains-secret-admin\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"tekton-chains-controller-leaderelection\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"tekton-chains-info\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"tekton-chains-public-key-viewer\",\"namespace\":\"tekton-chains\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"RoleBinding\",\"name\":\"tekton-results-info\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"route.openshift.io\",\"health\":{\"message\":\"Route is healthy\",\"status\":\"Healthy\"},\"kind\":\"Route\",\"name\":\"pipelines-as-code-controller\",\"namespace\":\"pipelines-as-code\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"route.openshift.io\",\"health\":{\"message\":\"Route is healthy\",\"status\":\"Healthy\"},\"kind\":\"Route\",\"name\":\"tekton-results\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"security.openshift.io\",\"kind\":\"SecurityContextConstraints\",\"name\":\"appstudio-pipelines-scc\",\"status\":\"Synced\",\"version\":\"v1\"}],\"sourceType\":\"Kustomize\",\"summary\":{\"images\":[\"ghcr.io/openshift-pipelines/pipelines-as-code-controller:v0.16.0\",\"ghcr.io/openshift-pipelines/pipelines-as-code-watcher:v0.16.0\",\"quay.io/minio/mc:RELEASE.2023-01-28T20-29-38Z\",\"quay.io/redhat-appstudio/appstudio-utils:eb94f28fe2d7c182f15e659d0fdb66f87b0b3b6b\",\"quay.io/redhat-appstudio/pipeline-service-exporter:450708aa46088d8b7e9e1915b8489ccbf8dbe47f\",\"quay.io/redhat-appstudio/tekton-results-api:4e0f90b46c4f6709ea768dd77d7d58651dbf0bec\",\"quay.io/redhat-appstudio/tekton-results-migrator:4e0f90b46c4f6709ea768dd77d7d58651dbf0bec\",\"quay.io/redhat-appstudio/tekton-results-watcher:4e0f90b46c4f6709ea768dd77d7d58651dbf0bec\",\"registry.redhat.io/openshift-pipelines/pipelines-chains-controller-rhel8:v1.10.2-1\"]},\"sync\":{\"comparedTo\":{\"destination\":{\"namespace\":\"openshift-gitops\",\"server\":\"https://kubernetes.default.svc\"},\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}},\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"status\":\"Synced\"}}}": strict decoding error: unknown field "spec.sources"
Error from server (Invalid): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{},\"name\":\"pipeline-service-storage\",\"namespace\":\"openshift-gitops\"},\"spec\":{\"destination\":{\"namespace\":\"tekton-results\",\"server\":\"https://kubernetes.default.svc\"},\"project\":\"default\",\"sources\":[{\"path\":\"developer/openshift/gitops/argocd/pipeline-service-storage/minio\",\"ref\":\"values\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"43e768066fa0f61b9634127d8280be634d48cdce\"},{\"chart\":\"postgresql\",\"helm\":{\"releaseName\":\"postgres\",\"valueFiles\":[\"$values/developer/openshift/gitops/argocd/pipeline-service-storage/postgres/values.yaml\"]},\"repoURL\":\"https://charts.bitnami.com/bitnami\",\"targetRevision\":\"12.2.7\"}],\"syncPolicy\":{\"automated\":{\"prune\":true,\"selfHeal\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"syncOptions\":[\"CreateNamespace=true\"]}}}\n"}},"spec":{"destination":{"namespace":"tekton-results"},"source":null,"sources":[{"path":"developer/openshift/gitops/argocd/pipeline-service-storage/minio","ref":"values","repoURL":"https://github.com/openshift-pipelines/pipeline-service.git","targetRevision":"43e768066fa0f61b9634127d8280be634d48cdce"},{"chart":"postgresql","helm":{"releaseName":"postgres","valueFiles":["$values/developer/openshift/gitops/argocd/pipeline-service-storage/postgres/values.yaml"]},"repoURL":"https://charts.bitnami.com/bitnami","targetRevision":"12.2.7"}]}}
to:
Resource: "argoproj.io/v1alpha1, Resource=applications", GroupVersionKind: "argoproj.io/v1alpha1, Kind=Application"
Name: "pipeline-service-storage", Namespace: "openshift-gitops"
for: "/source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com": error when patching "/source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com":  "" is invalid: patch: Invalid value: "{\"apiVersion\":\"argoproj.io/v1alpha1\",\"kind\":\"Application\",\"metadata\":{\"annotations\":{\"kubectl.kubernetes.io/last-applied-configuration\":\"{\\\"apiVersion\\\":\\\"argoproj.io/v1alpha1\\\",\\\"kind\\\":\\\"Application\\\",\\\"metadata\\\":{\\\"annotations\\\":{},\\\"name\\\":\\\"pipeline-service-storage\\\",\\\"namespace\\\":\\\"openshift-gitops\\\"},\\\"spec\\\":{\\\"destination\\\":{\\\"namespace\\\":\\\"tekton-results\\\",\\\"server\\\":\\\"https://kubernetes.default.svc\\\"},\\\"project\\\":\\\"default\\\",\\\"sources\\\":[{\\\"path\\\":\\\"developer/openshift/gitops/argocd/pipeline-service-storage/minio\\\",\\\"ref\\\":\\\"values\\\",\\\"repoURL\\\":\\\"https://github.com/openshift-pipelines/pipeline-service.git\\\",\\\"targetRevision\\\":\\\"43e768066fa0f61b9634127d8280be634d48cdce\\\"},{\\\"chart\\\":\\\"postgresql\\\",\\\"helm\\\":{\\\"releaseName\\\":\\\"postgres\\\",\\\"valueFiles\\\":[\\\"$values/developer/openshift/gitops/argocd/pipeline-service-storage/postgres/values.yaml\\\"]},\\\"repoURL\\\":\\\"https://charts.bitnami.com/bitnami\\\",\\\"targetRevision\\\":\\\"12.2.7\\\"}],\\\"syncPolicy\\\":{\\\"automated\\\":{\\\"prune\\\":true,\\\"selfHeal\\\":true},\\\"retry\\\":{\\\"backoff\\\":{\\\"duration\\\":\\\"10s\\\",\\\"factor\\\":2,\\\"maxDuration\\\":\\\"3m\\\"},\\\"limit\\\":-1},\\\"syncOptions\\\":[\\\"CreateNamespace=true\\\"]}}}\\n\"},\"creationTimestamp\":\"2023-06-18T23:14:51Z\",\"generation\":19,\"managedFields\":[{\"apiVersion\":\"argoproj.io/v1alpha1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:metadata\":{\"f:annotations\":{\".\":{},\"f:kubectl.kubernetes.io/last-applied-configuration\":{}}},\"f:spec\":{\".\":{},\"f:destination\":{\".\":{},\"f:namespace\":{},\"f:server\":{}},\"f:project\":{},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}},\"f:syncPolicy\":{\".\":{},\"f:automated\":{\".\":{},\"f:prune\":{},\"f:selfHeal\":{}},\"f:retry\":{\".\":{},\"f:backoff\":{\".\":{},\"f:duration\":{},\"f:factor\":{},\"f:maxDuration\":{}},\"f:limit\":{}},\"f:syncOptions\":{}}}},\"manager\":\"kubectl-client-side-apply\",\"operation\":\"Update\",\"time\":\"2023-06-18T23:14:51Z\"},{\"apiVersion\":\"argoproj.io/v1alpha1\",\"fieldsType\":\"FieldsV1\",\"fieldsV1\":{\"f:status\":{\".\":{},\"f:health\":{\".\":{},\"f:status\":{}},\"f:history\":{},\"f:operationState\":{\".\":{},\"f:finishedAt\":{},\"f:message\":{},\"f:operation\":{\".\":{},\"f:initiatedBy\":{\".\":{},\"f:automated\":{}},\"f:retry\":{\".\":{},\"f:backoff\":{\".\":{},\"f:duration\":{},\"f:factor\":{},\"f:maxDuration\":{}},\"f:limit\":{}},\"f:sync\":{\".\":{},\"f:prune\":{},\"f:revision\":{},\"f:syncOptions\":{}}},\"f:phase\":{},\"f:retryCount\":{},\"f:startedAt\":{},\"f:syncResult\":{\".\":{},\"f:resources\":{},\"f:revision\":{},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}}}},\"f:reconciledAt\":{},\"f:resources\":{},\"f:sourceType\":{},\"f:summary\":{\".\":{},\"f:images\":{}},\"f:sync\":{\".\":{},\"f:comparedTo\":{\".\":{},\"f:destination\":{\".\":{},\"f:namespace\":{},\"f:server\":{}},\"f:source\":{\".\":{},\"f:path\":{},\"f:repoURL\":{},\"f:targetRevision\":{}}},\"f:revision\":{},\"f:status\":{}}}},\"manager\":\"Go-http-client\",\"operation\":\"Update\",\"time\":\"2023-06-18T23:18:26Z\"}],\"name\":\"pipeline-service-storage\",\"namespace\":\"openshift-gitops\",\"resourceVersion\":\"18808\",\"uid\":\"360d29dc-235d-48b4-83e4-836869f57bfa\"},\"spec\":{\"destination\":{\"namespace\":\"tekton-results\",\"server\":\"https://kubernetes.default.svc\"},\"project\":\"default\",\"sources\":[{\"path\":\"developer/openshift/gitops/argocd/pipeline-service-storage/minio\",\"ref\":\"values\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"43e768066fa0f61b9634127d8280be634d48cdce\"},{\"chart\":\"postgresql\",\"helm\":{\"releaseName\":\"postgres\",\"valueFiles\":[\"$values/developer/openshift/gitops/argocd/pipeline-service-storage/postgres/values.yaml\"]},\"repoURL\":\"https://charts.bitnami.com/bitnami\",\"targetRevision\":\"12.2.7\"}],\"syncPolicy\":{\"automated\":{\"prune\":true,\"selfHeal\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"syncOptions\":[\"CreateNamespace=true\"]}},\"status\":{\"health\":{\"status\":\"Healthy\"},\"history\":[{\"deployStartedAt\":\"2023-06-18T23:14:56Z\",\"deployedAt\":\"2023-06-18T23:15:21Z\",\"id\":0,\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service-storage\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}}],\"operationState\":{\"finishedAt\":\"2023-06-18T23:15:21Z\",\"message\":\"successfully synced (all tasks run)\",\"operation\":{\"initiatedBy\":{\"automated\":true},\"retry\":{\"backoff\":{\"duration\":\"10s\",\"factor\":2,\"maxDuration\":\"3m\"},\"limit\":-1},\"sync\":{\"prune\":true,\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"syncOptions\":[\"CreateNamespace=true\"]}},\"phase\":\"Succeeded\",\"retryCount\":1,\"startedAt\":\"2023-06-18T23:14:56Z\",\"syncResult\":{\"resources\":[{\"group\":\"rbac.authorization.k8s.io\",\"hookPhase\":\"Running\",\"kind\":\"ClusterRole\",\"message\":\"clusterrole.rbac.authorization.k8s.io/openshift-minio-apply-tenants reconciled. clusterrole.rbac.authorization.k8s.io/openshift-minio-apply-tenants unchanged\",\"name\":\"openshift-minio-apply-tenants\",\"namespace\":\"openshift-gitops\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"hookPhase\":\"Running\",\"kind\":\"ClusterRoleBinding\",\"message\":\"clusterrolebinding.rbac.authorization.k8s.io/openshift-minio-apply-tenants reconciled. clusterrolebinding.rbac.authorization.k8s.io/openshift-minio-apply-tenants unchanged\",\"name\":\"openshift-minio-apply-tenants\",\"namespace\":\"openshift-gitops\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v1\"},{\"group\":\"operators.coreos.com\",\"hookPhase\":\"Running\",\"kind\":\"Subscription\",\"message\":\"subscription.operators.coreos.com/minio-operator unchanged\",\"name\":\"minio-operator\",\"namespace\":\"openshift-operators\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v1alpha1\"},{\"group\":\"argoproj.io\",\"hookPhase\":\"Running\",\"kind\":\"Application\",\"message\":\"application.argoproj.io/postgres unchanged\",\"name\":\"postgres\",\"namespace\":\"openshift-gitops\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v1alpha1\"},{\"group\":\"minio.min.io\",\"hookPhase\":\"Running\",\"kind\":\"Tenant\",\"message\":\"tenant.minio.min.io/storage created\",\"name\":\"storage\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"syncPhase\":\"Sync\",\"version\":\"v2\"}],\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service-storage\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}}},\"reconciledAt\":\"2023-06-18T23:18:26Z\",\"resources\":[{\"group\":\"argoproj.io\",\"kind\":\"Application\",\"name\":\"postgres\",\"namespace\":\"openshift-gitops\",\"status\":\"Synced\",\"version\":\"v1alpha1\"},{\"group\":\"minio.min.io\",\"health\":{\"message\":\"Initialized\",\"status\":\"Healthy\"},\"kind\":\"Tenant\",\"name\":\"storage\",\"namespace\":\"tekton-results\",\"status\":\"Synced\",\"version\":\"v2\"},{\"group\":\"operators.coreos.com\",\"health\":{\"message\":\"1: CatalogSourcesUnhealthy | False\\n\",\"status\":\"Healthy\"},\"kind\":\"Subscription\",\"name\":\"minio-operator\",\"namespace\":\"openshift-operators\",\"status\":\"Synced\",\"version\":\"v1alpha1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"openshift-minio-apply-tenants\",\"status\":\"Synced\",\"version\":\"v1\"},{\"group\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRoleBinding\",\"name\":\"openshift-minio-apply-tenants\",\"status\":\"Synced\",\"version\":\"v1\"}],\"sourceType\":\"Kustomize\",\"summary\":{\"images\":[\"quay.io/minio/minio:RELEASE.2022-09-17T00-09-45Z\",\"quay.io/minio/operator@sha256:1a32f5143f02e22acd5f2e368d98b783c069409ee550c0ddd0972db9a386d29a\"]},\"sync\":{\"comparedTo\":{\"destination\":{\"namespace\":\"openshift-gitops\",\"server\":\"https://kubernetes.default.svc\"},\"source\":{\"path\":\"developer/openshift/gitops/argocd/pipeline-service-storage\",\"repoURL\":\"https://github.com/openshift-pipelines/pipeline-service.git\",\"targetRevision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\"}},\"revision\":\"b8fb576cedf32b8262f8cbea9e6889d15b48c029\",\"status\":\"Synced\"}}}": strict decoding error: unknown field "spec.sources"
 -n tekton-results -o name --ignore-not-found
        + s3_secret=secret/tekton-results-s3
        + '[' -z secret/tekton-results-s3 ']'
        + printf 'OK\n'
        OK
    - Setting kustomize directory: /source/developer/openshift/work/environment/compute/api-ci-53b85bfcda-pozs-p3-openshiftapps-com
  - Deploy applications:
    - No Bitwarden secrets
    - Installing shared manifests... 
        namespace/tekton-results configured
    - Installing applications via Openshift GitOps... 
command terminated with exit code 1

as it is attempting to patch something in the tekton-results namespace. That said, I don't think it is one of the directory subtrees you directly impacted. Perhaps there is a relationship between what you changed and this path that failed?

If you analyzed this already and reported, apologies, I missed the analysis.

gabemontero avatar Jun 20 '23 15:06 gabemontero

@sayan-biswas PR needs a rebase.

Roming22 avatar Jul 07 '23 18:07 Roming22

@sayan-biswas What's the status on this PR. It seems to be stale.

Roming22 avatar Jul 27 '23 20:07 Roming22

@sayan-biswas What's the status on this PR. It seems to be stale.

@Roming22 I will rebase with the latest changes.

sayan-biswas avatar Jul 28 '23 08:07 sayan-biswas

PR is stale and not being actively worked on. Adding a WIP header.

Roming22 avatar Aug 07 '23 16:08 Roming22

Updated PR adjusting the new changes

sayan-biswas avatar Aug 31 '23 09:08 sayan-biswas

The changes look OK best to my understanding @sayan-biswas

Given the complexity / amount of change, attempting to bootstrap from infra-deployments where you point pipeline-service to your branch/commit for feels worthwhile, so that we "pre-validate" how this will look there before we couple this commit with our other commits.

Have you happened to do that already? If not, could you do it either before your EOB today or tomorrow, and then I'll merge once you say the infra-deployments bootstrap is setting up everything correctly as well. Just want to make sure nothing minio/postgresql related has leaked into infra-deployments that would conflict with this.

thanks

Sounds good. I'll do that today.

sayan-biswas avatar Sep 04 '23 15:09 sayan-biswas

The changes look OK best to my understanding @sayan-biswas Given the complexity / amount of change, attempting to bootstrap from infra-deployments where you point pipeline-service to your branch/commit for feels worthwhile, so that we "pre-validate" how this will look there before we couple this commit with our other commits. Have you happened to do that already? If not, could you do it either before your EOB today or tomorrow, and then I'll merge once you say the infra-deployments bootstrap is setting up everything correctly as well. Just want to make sure nothing minio/postgresql related has leaked into infra-deployments that would conflict with this. thanks

Sounds good. I'll do that today.

Were you able to verify @sayan-biswas ? If so, the PR is green and I can hit the merge button if everything checked out in infra-deployments.

gabemontero avatar Sep 06 '23 13:09 gabemontero

The changes look OK best to my understanding @sayan-biswas Given the complexity / amount of change, attempting to bootstrap from infra-deployments where you point pipeline-service to your branch/commit for feels worthwhile, so that we "pre-validate" how this will look there before we couple this commit with our other commits. Have you happened to do that already? If not, could you do it either before your EOB today or tomorrow, and then I'll merge once you say the infra-deployments bootstrap is setting up everything correctly as well. Just want to make sure nothing minio/postgresql related has leaked into infra-deployments that would conflict with this. thanks

Sounds good. I'll do that today.

Were you able to verify @sayan-biswas ? If so, the PR is green and I can hit the merge button if everything checked out in infra-deployments.

bump @sayan-biswas - were you able to do that infra-deployments based verification ?

gabemontero avatar Sep 07 '23 13:09 gabemontero

The changes look OK best to my understanding @sayan-biswas Given the complexity / amount of change, attempting to bootstrap from infra-deployments where you point pipeline-service to your branch/commit for feels worthwhile, so that we "pre-validate" how this will look there before we couple this commit with our other commits. Have you happened to do that already? If not, could you do it either before your EOB today or tomorrow, and then I'll merge once you say the infra-deployments bootstrap is setting up everything correctly as well. Just want to make sure nothing minio/postgresql related has leaked into infra-deployments that would conflict with this. thanks

Sounds good. I'll do that today.

Were you able to verify @sayan-biswas ? If so, the PR is green and I can hit the merge button if everything checked out in infra-deployments.

bump @sayan-biswas - were you able to do that infra-deployments based verification ?

Yes, I created a PR in infra-deployment and argoCD is failing to sync. I am debugging that. https://github.com/redhat-appstudio/infra-deployments/pull/2365

sayan-biswas avatar Sep 08 '23 08:09 sayan-biswas

@sayan-biswas Since you are still working on making sure this PR can be safely merged, I'll add WIP to the title.

Remove it when the PR can be merged.

Roming22 avatar Sep 08 '23 19:09 Roming22

@sayan-biswas Not a priority, but make sure this PR either go somewhere or is closed.

Roming22 avatar Oct 23 '23 18:10 Roming22