starter-guides icon indicating copy to clipboard operation
starter-guides copied to clipboard

s2i docs links are broken.

Open pittar opened this issue 3 years ago • 3 comments

There are links to the OpenShift documentation for s2i in two different modules. Both links are broken.

The 1st is in: https://github.com/openshift-labs/starter-guides/blob/ocp-4.6/workshop/content/nationalparks-java.adoc ("OpenShift S2I documentation" link)

The 2nd is in: https://github.com/openshift-labs/starter-guides/blob/ocp-4.6/workshop/content/mlbparks-binary-build.adoc ("official documentation" link)

pittar avatar Mar 04 '21 21:03 pittar

Thanks @pittar ! Would you send a PR for that? Or I can fix it from your input, thanks for reporting it!

blues-man avatar Mar 05 '21 11:03 blues-man

@blues-man Well... part of the problem is these sections don't seem to exist in 4.x docs.

For example, the 2nd link (binary builds) is in 3.11 docs, but doesn't seem to have a 4.x equivalent: https://docs.openshift.com/container-platform/3.11/dev_guide/dev_tutorials/binary_builds.html

My best guess for the first link is this one: https://docs.openshift.com/container-platform/4.7/cicd/builds/understanding-image-builds.html#builds-strategy-s2i-build_understanding-image-builds but again... it's not really the same section as the old 3.11 docs.

I'd make a PR, but I'm not sure where you want the new links to actually go.

pittar avatar Mar 06 '21 18:03 pittar

Hello @pittar, you are right. We also have to use 4.6 doc for this workshop, and I think you can use this link for S2I (nationalparks): https://docs.openshift.com/container-platform/4.6/builds/build-strategies.html#builds-strategy-s2i-build_build-strategies And this doc about binary builds (MLBParks): https://docs.openshift.com/container-platform/4.6/builds/creating-build-inputs.html#builds-define-build-inputs_creating-build-inputs

blues-man avatar Mar 10 '21 09:03 blues-man