opensheetmusicdisplay icon indicating copy to clipboard operation
opensheetmusicdisplay copied to clipboard

MusicXML Test Suite

Open rvilarl opened this issue 2 years ago • 3 comments

addresses #1169

rvilarl avatar May 16 '22 21:05 rvilarl

Nice. How did you get the xmls? (official links were dead)

Still not sure what exactly we should do with this. Maybe put it into a separate folder, and do separate visual regression tests for them. A lot of these tests are basically duplicates of what we're already testing with our samples, so if we just lumped everything together, we'd get duplicate visual regressions, basically. (same issues, slightly different samples)

sschmidTU avatar May 16 '22 22:05 sschmidTU

In the page https://lilypond.org/doc/v2.20/input/regression/musicxml/collated-files#test-cases you find:

Downloading the test suite

The complete set of MusicXML test files contained in this suite can be downloaded here as a ZIP archive.

rvilarl avatar May 17 '22 03:05 rvilarl

@rvilarl Let's put this test suite into a separate folder in test/data, like test/data/lilypond_test_suite, as I said, also because it has a lot of duplicate test cases to our own, and would significantly increase the runtime of visual regression tests. I just ran the test suite only, and it takes around 7 seconds for generating the images and 28 seconds for visual regression (and this is on a pretty fast/recent machine). This would be in addition to the current test time, as I excluded our current test samples for this run.

So for the generate and test:visual scripts, I would add an option to include the lilypond samples and perhaps disable it by default. I can do this adaptation to the generateImages script so that you don't have to. In that case you can just move the files to the new folder and I'll merge (tests won't use the subfolder yet) and adapt from there.

One more slight issue is that most of these tests don't have titles set in the XML, so OSMD says "Loaded sheet Untitled score" a lot. In this case I can also fix the generateImages script so that it sets the title by filename if it doesn't have an XML title. (edit: done)

sschmidTU avatar May 19 '22 18:05 sschmidTU