osm icon indicating copy to clipboard operation
osm copied to clipboard

feat(certs): adds check to move componentStatuses to Validating

Open shalier opened this issue 2 years ago • 1 comments

Description: Adds check that the MRC meets the attribute required to move the component statuses to Validating and resolves #5181

Signed-off-by: Shalier Xia [email protected]

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

shalier avatar Oct 04 '22 00:10 shalier

Codecov Report

Merging #5186 (c5e170b) into main (8cf4c94) will decrease coverage by 0.57%. The diff coverage is 28.69%.

@@            Coverage Diff             @@
##             main    #5186      +/-   ##
==========================================
- Coverage   67.93%   67.36%   -0.58%     
==========================================
  Files         197      198       +1     
  Lines       16002    16177     +175     
==========================================
+ Hits        10871    10897      +26     
- Misses       5078     5227     +149     
  Partials       53       53              
Flag Coverage Δ
unittests 67.36% <28.69%> (-0.58%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/mock_catalog_generated.go 0.00% <0.00%> (ø)
pkg/certificate/certificate.go 82.97% <ø> (ø)
pkg/certificate/fake_manager.go 75.53% <0.00%> (-4.06%) :arrow_down:
pkg/certificate/providers/compat.go 62.50% <0.00%> (-8.93%) :arrow_down:
pkg/certificate/providers/mrc.go 33.33% <0.00%> (-3.04%) :arrow_down:
pkg/certificate/types.go 100.00% <ø> (ø)
pkg/k8s/mock_controller_generated.go 3.33% <0.00%> (-0.11%) :arrow_down:
pkg/k8s/types.go 100.00% <ø> (ø)
pkg/utils/mesh_config.go 0.00% <0.00%> (ø)
pkg/certificate/mrc_reconciler.go 11.68% <11.68%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 04 '22 00:10 codecov-commenter

Closing for now in favor of #5201. Will revisit in milestone 1.4

jaellio avatar Oct 17 '22 16:10 jaellio