osm icon indicating copy to clipboard operation
osm copied to clipboard

Remove pkg/debugger dependency on k8s.Controller

Open steeling opened this issue 3 years ago • 2 comments
trafficstars

The debugger package shouldn't need a dependency on k8s.Controller. Currently it calls GetPodForProxy, and uses the pod info to port-forward.

ie: PortForwardToProxy(ctx context.Context, proxy *envoy.Proxy, int localPort) (close func(), error). This should replace the calls in pkg/debugger, such that we can remove the k8s.Controller for the debug struct.

steeling avatar Sep 27 '22 15:09 steeling

The PortForwardToProxy method should exist on the compute client in pkg/compute/kube

steeling avatar Oct 10 '22 18:10 steeling

The PortForwardToProxy method should exist on the compute client in pkg/compute/kube

steeling avatar Oct 10 '22 18:10 steeling