osm icon indicating copy to clipboard operation
osm copied to clipboard

feat(certs): handle MRCUpdated event when intent set passive

Open jaellio opened this issue 3 years ago • 1 comments
trafficstars

Description:

Adds logic to update MRC conditions and components. Handles MRCUpdated event when intent set to passive.

Part of #5091

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

jaellio avatar Sep 21 '22 22:09 jaellio

I'd personally prefer to see a PR like this come before https://github.com/openservicemesh/osm/pull/5073. I think there's a lot of caveats like how many can run at once (might infer if we need a mutex, how the MRCReconciler signifies that it is done reconciling, or other implementation details). Curious on your thoughts and how others may feel though

steeling avatar Sep 22 '22 00:09 steeling

Closing in favor of #5201

jaellio avatar Oct 21 '22 17:10 jaellio