Route builder for RDS

[nshankar13]

trafficstars

Signed-off-by: nshankar13 [email protected]

Description: Resolves https://github.com/openservicemesh/osm/issues/4924

Testing done:

Affected area:

Functional Area
New Functionality	[ ]
CI System	[ ]
CLI Tool	[ ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ ]
Documentation	[ ]
Egress	[ ]
Ingress	[ ]
Install	[ ]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[ ]
Tests	[ ]
Upgrade	[ ]
Other	[ ]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project?

   • Did you notify the maintainers and provide attribution?

2. Is this a breaking change?

3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

[nshankar13]

@steeling @shashankram few thoughts:

1. Wasn't sure if "getTrafficPolicy" methods should be in builder or remain in response.go.
2. Bulk of route config building was happening already in route_config.go. Should we merge this into the builder class, or continue to keep them separate? Advantage of having them separate is that builder.go code looks a lot cleaner and more intuitive.

[nshankar13]

Putting this on hold temporarily until globalRateLimiting has been merged, but plan on updating this with by moving some of the methods in route_config (BuildInboundMeshConfiguration) etc, to builder.go, and editing the tests accordingly.

[steeling]

approved! please make sure tests pass before submitting :)

[codecov-commenter]

Codecov Report

Merging #4973 (7093093) into main (4d8c632) will increase coverage by 0.05%. The diff coverage is 91.83%.

@@            Coverage Diff             @@
##             main    #4973      +/-   ##
==========================================
+ Coverage   69.57%   69.63%   +0.05%     
==========================================
  Files         199      200       +1     
  Lines       15400    15453      +53     
==========================================
+ Hits        10715    10760      +45     
- Misses       4629     4637       +8     
  Partials       56       56              

Flag	Coverage Δ
unittests	69.63% <91.83%> (+0.05%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/envoy/rds/rbac.go	92.85% <ø> (ø)
pkg/envoy/rds/response.go	66.66% <73.68%> (ø)
pkg/envoy/rds/builder.go	93.91% <93.91%> (ø)
pkg/cli/verifier/envoy_config.go	65.53% <100.00%> (ø)
pkg/envoy/lds/egress.go	80.55% <100.00%> (ø)
pkg/envoy/lds/ingress.go	85.71% <100.00%> (ø)
pkg/envoy/lds/inmesh.go	82.87% <100.00%> (ø)
pkg/envoy/rds/route_config.go	92.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.