Update envoy version to v1.23, and contour to v1.22

[nshankar13]

Signed-off-by: nshankar13 [email protected]

Description: Update envoy version to v1.23. To make this compatible with contour, we will also need to bump contour to v1.22.

Checked the release notes of envoy v1.23, nothing here seems to impact OSM. https://www.envoyproxy.io/docs/envoy/v1.23.0/version_history/v1.23/v1.23.0

Contour v1.22.0 changelog also does not impact OSM: https://github.com/projectcontour/contour/releases/v1.22.0

Testing done: Testing sidecar injection on ARM64 machines to ensure that correct envoy-distroless image is being pulled and injected.

Affected area:

Functional Area
New Functionality	[ ]
CI System	[ ]
CLI Tool	[ ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ ]
Documentation	[ ]
Egress	[ ]
Ingress	[ ]
Install	[ ]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[X]
Tests	[ ]
Upgrade	[ ]
Other	[ ]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project?

   • Did you notify the maintainers and provide attribution?

2. Is this a breaking change?

3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

[codecov-commenter]

Codecov Report

Merging #4954 (30e6733) into main (794d8ea) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4954      +/-   ##
==========================================
- Coverage   68.76%   68.75%   -0.02%     
==========================================
  Files         220      220              
  Lines       16048    16048              
==========================================
- Hits        11036    11033       -3     
- Misses       4960     4963       +3     
  Partials       52       52              

Flag	Coverage Δ
unittests	68.75% <ø> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/messaging/workqueue.go	89.28% <0.00%> (-10.72%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 794d8ea...30e6733. Read the comment docs.

[jsturtevant]

@nshankar13 anything holding this back? Seems like we should get this in early in the release cycle for 1.3 to get test coverage. Could you do the rebase required?

[nshankar13]

@jsturtevant yep we're blocked because the ARM image for envoy-distroless v1.23.0 doesn't have the correct binary: https://github.com/openservicemesh/osm/issues/4716#issuecomment-1203111096. I was instead thinking we should just wait for envoy-distroless:v1.23.1 so that way we could also have the multi-arch issue sorted out.

However, if we need envoy v1.23.0 in soon I can go ahead and restart this PR, and wait until v1.23.1 and do that as a separate update for the ARM64 testing.

[jsturtevant]

do we currently support ARM? If we don't then wouldn't block upgrading early in the cycle.

[nshankar13]

Good point, we don't. I'll get this PR restarted again.

[odidev]

However, if we need envoy v1.23.0 in soon I can go ahead and restart this PR, and wait until v1.23.1 and do that as a separate update for the ARM64 testing.

@nshankar13 envoy-distroless v1.23.1 is released in dockerhub

[nshankar13]

Thanks @odidev, will update to envoy-distroless v1.23.1 and test again.

[nshankar13]

Actually @odidev, we will also need to wait for contour to support envoy v1.23.1 as well, putting this on hold until that's available: https://github.com/projectcontour/contour/releases/

[keithmattix]

FWIW Looks like that new release is coming soon: https://github.com/projectcontour/contour/pull/4693

[keithmattix]

@nshankar13 New contour version was just released!

[keithmattix]

Approving pending green CI

[nshankar13]

Still need to test Contour demo and sidecar injection, hold off on merging until then.

[nshankar13]

@keithmattix @shashankram Tested sidecar injection on ARM64 and ran the contour demo successfully, and updated PR description.