osm icon indicating copy to clipboard operation
osm copied to clipboard

ServiceMonitor feature

Open nlamirault opened this issue 3 years ago • 2 comments

Please describe the Improvement and/or Feature Request

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Demo [ ]
  • Project Release [ ]

Possible use cases

A lot of Helm charts could create Kubernetes resources (ServiceMonitor, PodMonitor, ...) managed by the Prometheus Operator. Ex:

It would be interesting to have such a feature into the Helm chart.

nlamirault avatar Apr 27 '22 09:04 nlamirault

It would be interesting to have such a feature into the Helm chart.

@nlamirault Thanks for opening this issue. Could you describe in the issue why this is required and how is it useful. Adding additional context will help us review this requirement better and see how we can integrate it into our existing observability story.

shashankram avatar May 04 '22 16:05 shashankram

Not the OP but maybe i can provide more context. The Prometheus Operator deployed by kube-prometheus-stack (and probably other projects) does not support the prometheus.io annotations , and instead uses PodMonitor/ServiceMonitor CRDS to figure out what to scrape. It would be convenient for OSM to support these methods.

Other issues i noticed in the same vein:

  • https://github.com/openservicemesh/osm/issues/4780
  • https://github.com/openservicemesh/osm/issues/1537

defenestration avatar Jun 16 '22 15:06 defenestration

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

github-actions[bot] avatar Sep 17 '22 00:09 github-actions[bot]

Issue closed due to inactivity.

github-actions[bot] avatar Sep 24 '22 00:09 github-actions[bot]