osm icon indicating copy to clipboard operation
osm copied to clipboard

[helm chart] ServiceMonitor support

Open nlamirault opened this issue 3 years ago • 7 comments

Description: Enable OSM monitoring using a ServiceMonitor

See : #4699

Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No.

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

nlamirault avatar Apr 26 '22 07:04 nlamirault

@nlamirault thanks for contributing. Could you open up an issue describing the need for this change so we can discuss further. Thanks

shashankram avatar Apr 26 '22 16:04 shashankram

Done @shashankram

nlamirault avatar Apr 27 '22 09:04 nlamirault

This PR will be closed due to a long period of inactivity. If you would like this PR to remain open then please comment or update.

github-actions[bot] avatar Jun 27 '22 00:06 github-actions[bot]

/remove stale

nlamirault avatar Jun 27 '22 07:06 nlamirault

This PR will be closed due to a long period of inactivity. If you would like this PR to remain open then please comment or update.

github-actions[bot] avatar Aug 28 '22 00:08 github-actions[bot]

Codecov Report

Merging #4693 (54434ae) into main (6fc993b) will decrease coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4693      +/-   ##
==========================================
- Coverage   67.13%   67.11%   -0.02%     
==========================================
  Files         200      200              
  Lines       16442    16442              
==========================================
- Hits        11038    11035       -3     
- Misses       5350     5353       +3     
  Partials       54       54              
Flag Coverage Δ
unittests 67.11% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ticker/ticker.go 82.66% <0.00%> (-4.00%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 01 '22 16:09 codecov-commenter

@nlamirault Could you please update the charts by running make check-charts at the root of the project?

jaellio avatar Sep 28 '22 19:09 jaellio

make check-charts where do you find this command ? @jaellio

nlamirault avatar Oct 24 '22 06:10 nlamirault

Hi @nlamirault, at the root of the OSM project there is a makefile that defines the check-charts tag. The check-charts task will regenerate charts/osm/README.md. In your branch, if you navigate to the root of the repository and run make check-charts the task will run and you can push a new commit. Let me know if you have any questions!

jaellio avatar Nov 02 '22 21:11 jaellio

Closing this PR for now due to inactivity. @nlamirault please comment on the PR and tag me if you would like this to be reopened! Thanks!

jaellio avatar Nov 28 '22 18:11 jaellio