cli: NS removed from mesh when uninstalling mesh

[mudit-01]

"osm uninstall mesh" removes osm-related labels and annotations from the monitored namespace, partially fixes https://github.com/openservicemesh/osm/issues/4444

Signed-off-by: mudit singh [email protected]

Description:

Testing done: yes

Affected area:

Functional Area
New Functionality	[ ]
CI System	[ ]
CLI Tool	[x ]
Certificate Management	[ ]
Control Plane	[ ]
Demo	[ ]
Documentation	[ ]
Egress	[ ]
Ingress	[ ]
Install	[ ]
Networking	[ ]
Observability	[ ]
Performance	[ ]
SMI Policy	[ ]
Security	[ ]
Sidecar Injection	[ ]
Tests	[ ]
Upgrade	[ ]
Other	[ ]

Please answer the following questions with yes/no.

1. Does this change contain code from or inspired by another project?

   • Did you notify the maintainers and provide attribution?

2. Is this a breaking change?

3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

[codecov-commenter]

Codecov Report

Merging #4555 (d019aab) into main (1ae2578) will increase coverage by 0.02%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #4555      +/-   ##
==========================================
+ Coverage   68.10%   68.13%   +0.02%     
==========================================
  Files         195      195              
  Lines       15707    15718      +11     
==========================================
+ Hits        10697    10709      +12     
+ Misses       4957     4956       -1     
  Partials       53       53              

Flag	Coverage Δ
unittests	68.13% <83.33%> (+0.02%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/cli/uninstall_mesh.go	70.28% <83.33%> (+0.37%)	:arrow_up:
cmd/cli/util.go	71.64% <0.00%> (+1.54%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[mudit-01]

@snehachhabria @shashankram @jaellio @nojnhuh please suggest, if there are any changes for the PR.

[mudit-01]

Can we merge this PR?

[shashankram]

Hey @mudit-01, this PR has some conflicts with the version in main. Would you mind rebasing/merging your changes with the main branch.

[mudit-01]

Thanks @shashankram I will work on resolving asap

[mudit-01]

Hi @shashankram need help in resolving the lint error(cyclomatic complexity). How can I remove that currently it's 32 just 2 more than the threshold?

[shalier]

@mudit-01 the cyclomatic complexity error should be fixed now and with @jaellio's fix the lint check should pass

[mudit-01]

Thanks, @shalier there seems to be a problem with a test after the commit. How can we rerun it later?

[mudit-01]

Thanks! @allenlsy for the review :)

[mudit-01]

Thanks!! @jaellio @keithmattix for the review