osb-checker icon indicating copy to clipboard operation
osb-checker copied to clipboard

Synchronous response to client who advertises accepts_incomplete

Open jim-minter opened this issue 7 years ago • 3 comments

I think that reading the spec, it is permitted (implementation specific) for a broker with asynchronous capabilities to decide to send a synchronous provision/deprovision response to a client, regardless of whether the client advertises accepts_incomplete or not. I think that at the moment osb-checker doesn't bear this in mind.

jim-minter avatar Dec 04 '17 21:12 jim-minter

@norshtein @zhongyi-zhang Any thought?

leonwanghui avatar Nov 20 '18 12:11 leonwanghui

That's true. But I think the checker does allow async or sync response. Provision: https://github.com/openservicebrokerapi/osb-checker/blob/master/2.13/tests/test/test.js#L237 Deprovision: https://github.com/openservicebrokerapi/osb-checker/blob/master/2.13/tests/test/test.js#L501 And async bind is not yet supported in OSB API 2.13.

Is there anything I missed?

zhongyi-zhang avatar Nov 21 '18 02:11 zhongyi-zhang

From my perspective, here is the current sync/async support matrix:

Broker Support Config accept_incomplete Result
async sync false -
async async true ✔️
sync sync false ✔️
sync async true ✔️

So I think what @jim-minter trying to express is we should support the first option because logically it's right but according to spec Service Brokers that cannot guarantee completion of the operation with the response SHOULD implement the asynchronous response, IMO it's broker authors' duty to guarantee the consistency between broker capabilities and config file.

Any thought?

leonwanghui avatar Dec 11 '18 03:12 leonwanghui