sql icon indicating copy to clipboard operation
sql copied to clipboard

Enable ignored and disabled tests

Open GumpacG opened this issue 2 years ago • 1 comments

Description

  • Enabled ignored and disabled tests.
  • Created https://github.com/opensearch-project/sql/issues/922, https://github.com/opensearch-project/sql/issues/917, https://github.com/opensearch-project/sql/issues/912, https://github.com/opensearch-project/sql/issues/910 and attached them to disabled tests for traceability.
  • Removed irrelevant tests.

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • [x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

GumpacG avatar Oct 18 '22 17:10 GumpacG

Codecov Report

Merging #926 (16f6714) into 2.x (c3840b6) will decrease coverage by 3.01%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #926      +/-   ##
============================================
- Coverage     97.90%   94.88%   -3.02%     
- Complexity     3072     3153      +81     
============================================
  Files           293      315      +22     
  Lines          7588     8532     +944     
  Branches        490      631     +141     
============================================
+ Hits           7429     8096     +667     
- Misses          158      382     +224     
- Partials          1       54      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 97.57% <ø> (-0.34%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rch/planner/physical/MLCommonsOperatorActions.java 1.29% <0.00%> (-0.46%) :arrow_down:
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <0.00%> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <0.00%> (ø)
...java/org/opensearch/sql/ppl/parser/AstBuilder.java 100.00% <0.00%> (ø)
...ava/org/opensearch/sql/utils/SystemIndexUtils.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/ppl/config/PPLServiceConfig.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/sql/config/SQLServiceConfig.java 100.00% <0.00%> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <0.00%> (ø)
...opensearch/sql/planner/logical/LogicalPlanDSL.java 100.00% <0.00%> (ø)
...pensearch/sql/ppl/parser/AstExpressionBuilder.java 100.00% <0.00%> (ø)
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 19 '22 19:10 codecov-commenter