sql icon indicating copy to clipboard operation
sql copied to clipboard

Add FILLNULL command in PPL (#3032)

Open normanj-bitquill opened this issue 1 year ago • 2 comments

Description

Adds the FILLNULL command for PPL. FILLNULL will replace NULL values in specified fields.

Related Issues

Resolves #3032

Check List

  • [Y] New functionality includes testing.
  • [Y] New functionality has been documented.
  • [Y] New functionality has javadoc added.
  • [Y] New functionality has a user manual doc added.
  • [N/A] API changes companion pull request created.
  • [Y] Commits are signed per the DCO using --signoff.
  • [?] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

normanj-bitquill avatar Oct 16 '24 19:10 normanj-bitquill

@MaxKsyunz I have added some integration tests.

normanj-bitquill avatar Oct 21 '24 16:10 normanj-bitquill

@jduo I have added an explain test.

normanj-bitquill avatar Oct 21 '24 16:10 normanj-bitquill

@normanj-bitquill please lets align the docs with the existing ppl fillnull doc in spark

@YANG-DB The docs have been updated to match the docs for Spark. The sample queries are still different, since they are run in this repo.

normanj-bitquill avatar Nov 27 '24 23:11 normanj-bitquill

@normanj-bitquill plz fix the keywordsCanBeId list and we can merge

@YANG-DB I have added it.

normanj-bitquill avatar Nov 28 '24 17:11 normanj-bitquill

Can we do this?

  • [x] Public documentation issue/PR created.

acarbonetto avatar Dec 03 '24 18:12 acarbonetto

@normanj-bitquill LGTM

  • @acarbonetto @Yury-Fridlyand @MaxKsyunz : can we approve and merge ? thanks

YANG-DB avatar Dec 04 '24 21:12 YANG-DB