sql
sql copied to clipboard
Lookup
Description
[Describe what this change achieves] Implementation of the new lookup command.
Issues Resolved
[List any issues this PR will resolve] https://github.com/opensearch-project/sql/issues/2651
Check List
- [ ] New functionality includes testing.
- [ ] All tests pass, including unit test, integration test and doctest
- [ ] New functionality has been documented.
- [ ] New functionality has javadoc added
- [ ] New functionality has user manual doc added
- [ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Is this ready for review now? Can you please rebase with latest main to fix CI?
@rupal-bq I will rebase.
Can you please add reference manual for lookup command? (e.g. https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/cmd/dedup.rst)
I rebased and squashed the commits and fixed DCO
Can you please add reference manual for lookup command? (e.g. https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/cmd/dedup.rst)
done
@salyh some tests failed. Can you please take a look?
@rupal-bq We have issues with the CI which are not caused by the code changes, for example:
| Exception in thread "main" java.lang.IllegalStateException: opensearch-security requires Java 21:, your system: 17.0.11+9
| at org.opensearch.bootstrap.JarHell.checkJavaVersion(JarHell.java:278)
| at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:403)
| at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:819)
| at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:874)
| at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276)
| at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250)
| at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
| at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| at org.opensearch.cli.Command.main(Command.java:101)
| at org.opensearch.plugins.PluginCli.main(PluginCli.java:66)
https://github.com/opensearch-project/sql/actions/runs/9764080193/job/26953624605?pr=2698
@rupal-bq We have issues with the CI which are not caused by the code changes, for example:
| Exception in thread "main" java.lang.IllegalStateException: opensearch-security requires Java 21:, your system: 17.0.11+9 | at org.opensearch.bootstrap.JarHell.checkJavaVersion(JarHell.java:278) | at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:403) | at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:819) | at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:874) | at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276) | at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250) | at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104) | at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) | at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104) | at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138) | at org.opensearch.cli.Command.main(Command.java:101) | at org.opensearch.plugins.PluginCli.main(PluginCli.java:66)https://github.com/opensearch-project/sql/actions/runs/9764080193/job/26953624605?pr=2698
Issue is fixed in main now. Can you please rebase?
This PR is stalled because it has been open for 30 days with no activity.
As PPL migrate to calcite https://github.com/opensearch-project/sql/issues/3229, lookup/join will be handled in calcite. could we close this PR.
As PPL migrate to calcite #3229, lookup/join will be handled in calcite. could we close this PR.
Resolved by https://github.com/opensearch-project/sql/issues/3358, close.