sql icon indicating copy to clipboard operation
sql copied to clipboard

Lookup

Open lukasz-soszynski-eliatra opened this issue 1 year ago • 8 comments

Description

[Describe what this change achieves] Implementation of the new lookup command.

Issues Resolved

[List any issues this PR will resolve] https://github.com/opensearch-project/sql/issues/2651

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is this ready for review now? Can you please rebase with latest main to fix CI?

rupal-bq avatar Jun 07 '24 18:06 rupal-bq

@rupal-bq I will rebase.

salyh avatar Jun 12 '24 11:06 salyh

Can you please add reference manual for lookup command? (e.g. https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/cmd/dedup.rst)

rupal-bq avatar Jun 13 '24 06:06 rupal-bq

I rebased and squashed the commits and fixed DCO

salyh avatar Jun 13 '24 09:06 salyh

Can you please add reference manual for lookup command? (e.g. https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/cmd/dedup.rst)

done

salyh avatar Jun 25 '24 11:06 salyh

@salyh some tests failed. Can you please take a look?

rupal-bq avatar Jul 01 '24 20:07 rupal-bq

@rupal-bq We have issues with the CI which are not caused by the code changes, for example:

 | Exception in thread "main" java.lang.IllegalStateException: opensearch-security requires Java 21:, your system: 17.0.11+9
| 	at org.opensearch.bootstrap.JarHell.checkJavaVersion(JarHell.java:278)
| 	at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:403)
| 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:819)
| 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:874)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250)
| 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.Command.main(Command.java:101)
| 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:66)

https://github.com/opensearch-project/sql/actions/runs/9764080193/job/26953624605?pr=2698

salyh avatar Jul 03 '24 15:07 salyh

@rupal-bq We have issues with the CI which are not caused by the code changes, for example:

 | Exception in thread "main" java.lang.IllegalStateException: opensearch-security requires Java 21:, your system: 17.0.11+9
| 	at org.opensearch.bootstrap.JarHell.checkJavaVersion(JarHell.java:278)
| 	at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:403)
| 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:819)
| 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:874)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:276)
| 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:250)
| 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
| 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
| 	at org.opensearch.cli.Command.main(Command.java:101)
| 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:66)

https://github.com/opensearch-project/sql/actions/runs/9764080193/job/26953624605?pr=2698

Issue is fixed in main now. Can you please rebase?

rupal-bq avatar Jul 09 '24 05:07 rupal-bq

This PR is stalled because it has been open for 30 days with no activity.

As PPL migrate to calcite https://github.com/opensearch-project/sql/issues/3229, lookup/join will be handled in calcite. could we close this PR.

penghuo avatar Feb 11 '25 19:02 penghuo

As PPL migrate to calcite #3229, lookup/join will be handled in calcite. could we close this PR.

Resolved by https://github.com/opensearch-project/sql/issues/3358, close.

LantaoJin avatar Mar 31 '25 07:03 LantaoJin