sql icon indicating copy to clipboard operation
sql copied to clipboard

Support geopoint type for Tableau

Open GumpacG opened this issue 1 year ago • 1 comments

Description

Supports geo_point by adding properties for lat and lon in order for Tableau/Power BI to access locations. This PR will only support the format {"lat": number, "lon": number}. Geopoint will be treated as an ExprTupleValue to allow access to lat and lon properties.

Expect results on Tableau when https://github.com/opensearch-project/sql/issues/1793 is resolved: Screenshot 2023-07-10 at 8 18 32 AM

Follow up work:

  • Support Geopoint type in JDBC (https://github.com/opensearch-project/sql-jdbc/issues/99)
  • Resolve https://github.com/opensearch-project/sql/issues/1793 in order for BI tools to use geopoint
  • Support other formats of Geopoint

Check List

  • [ ] New functionality includes testing.
    • [ ] All tests pass, including unit test, integration test and doctest
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
    • [ ] New functionality has user manual doc added
  • [ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

GumpacG avatar Jul 27 '23 21:07 GumpacG

Codecov Report

Merging #1910 (7286f9a) into main (ed2b683) will decrease coverage by 0.01%. Report is 1 commits behind head on main. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1910      +/-   ##
============================================
- Coverage     97.30%   97.30%   -0.01%     
+ Complexity     4623     4621       -2     
============================================
  Files           407      407              
  Lines         11935    11933       -2     
  Branches        828      830       +2     
============================================
- Hits          11613    11611       -2     
  Misses          315      315              
  Partials          7        7              
Flag Coverage Δ
sql-engine 97.30% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...h/sql/opensearch/data/type/OpenSearchDataType.java 100.00% <ø> (ø)
...l/opensearch/data/type/OpenSearchGeoPointType.java 100.00% <100.00%> (ø)
...l/opensearch/data/utils/OpenSearchJsonContent.java 100.00% <100.00%> (ø)
...search/data/value/OpenSearchExprGeoPointValue.java 100.00% <100.00%> (ø)

codecov[bot] avatar Jul 27 '23 22:07 codecov[bot]