spring-data-opensearch icon indicating copy to clipboard operation
spring-data-opensearch copied to clipboard

[BUG] Leftover references to Elasticsearch

Open dblock opened this issue 3 years ago • 3 comments

What is the bug?

We have a ton of Elasticsearch references in code, https://github.com/opensearch-project/spring-data-opensearch/search?q=Elasticsearch. What's the plan to deprecate those in favor of OpenSearch?

What is the expected behavior?

All "elasticsearch" becomes "opensearch".

dblock avatar Oct 12 '22 21:10 dblock

@dblock large chunk of them is expectable: we do rely on Spring Data Elasticsearch and as such, many classes / inrteraces / beans contain Elasticsearch in their names, no much we can do about it sadly (but there could be some leftovers indeed).

reta avatar Oct 18 '22 18:10 reta

Can our own code, such as this package, move from org.springframework.data.elasticsearch.core to an 'opensearch' namespace?

dblock avatar Oct 19 '22 12:10 dblock

Can our own code, such as this package, move from org.springframework.data.elasticsearch.core to an 'opensearch' namespace?

The org.springframework.data.elasticsearch.core (under test only) is 1:1 copy of the spring-data-elasticsearch test scaffolding, technically we can move it under our own package, I have mentioned it here https://github.com/opensearch-project/spring-data-opensearch/pull/1#issuecomment-1271774868

reta avatar Oct 19 '22 12:10 reta