security icon indicating copy to clipboard operation
security copied to clipboard

Remove whitelist settings in favor of allowlist

Open shikharj05 opened this issue 9 months ago • 1 comments

Description

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation) Maintenance
  • Why these changes are required? Removal of non-inclusive keywords from OpenSearch - https://opensearch.org/docs/latest/breaking-changes/#deprecate-non-inclusive-terms. Aligned with https://github.com/opensearch-project/OpenSearch/issues/1483
  • What is the old behavior before changes and new behavior after changes?

Is this a backport? If so, please add backport PR # and/or commits #, and remove backport-failed label from the original PR.

Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • [] New functionality includes testing
  • [X] New functionality has been documented
  • [NA] New Roles/Permissions have a corresponding security dashboards plugin PR
  • [NA] API changes companion pull request created
  • [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

shikharj05 avatar Mar 28 '25 11:03 shikharj05

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.70%. Comparing base (da21abf) to head (f0b91b3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5224      +/-   ##
==========================================
- Coverage   71.70%   71.70%   -0.01%     
==========================================
  Files         337      335       -2     
  Lines       22789    22736      -53     
  Branches     3606     3596      -10     
==========================================
- Hits        16341    16302      -39     
+ Misses       4650     4639      -11     
+ Partials     1798     1795       -3     
Files with missing lines Coverage Δ
...ty/configuration/ConfigurationLoaderSecurity7.java 70.24% <100.00%> (ø)
...ecurity/configuration/ConfigurationRepository.java 79.84% <ø> (-0.08%) :arrow_down:
...rg/opensearch/security/dlic/rest/api/Endpoint.java 100.00% <ø> (ø)
...security/dlic/rest/api/SecurityRestApiActions.java 80.00% <ø> (ø)
...opensearch/security/filter/SecurityRestFilter.java 85.07% <100.00%> (-0.44%) :arrow_down:
...ch/security/securityconf/DynamicConfigFactory.java 62.32% <ø> (-0.18%) :arrow_down:
...g/opensearch/security/securityconf/impl/CType.java 93.02% <ø> (-0.16%) :arrow_down:
...nsearch/security/support/SecurityIndexHandler.java 93.39% <100.00%> (-0.13%) :arrow_down:
...a/org/opensearch/security/tools/SecurityAdmin.java 48.51% <ø> (+0.17%) :arrow_up:

... and 4 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 28 '25 12:03 codecov[bot]